From cd06827a1c6572b136025b797a91062f24e4da98 Mon Sep 17 00:00:00 2001
From: caem <me@caem.dev>
Date: Sat, 25 Jan 2025 13:57:09 +0100
Subject: [PATCH] actually set the value

---
 modules/nixos/multimedia/web/firefox/preferences.nix | 2 +-
 overlays/nixpak/firefox.nix                          | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/modules/nixos/multimedia/web/firefox/preferences.nix b/modules/nixos/multimedia/web/firefox/preferences.nix
index 79985f2..6cf1428 100644
--- a/modules/nixos/multimedia/web/firefox/preferences.nix
+++ b/modules/nixos/multimedia/web/firefox/preferences.nix
@@ -17,5 +17,5 @@ let
         (n: v: ''user_pref("${n}", "${(prefToString v)}");'') prefs));
 in 
   mkPrefs {
-    "browser.urlbar.suggest.topsites" = "false";
+    "browser.urlbar.suggest.topsites" = false;
   }
diff --git a/overlays/nixpak/firefox.nix b/overlays/nixpak/firefox.nix
index 1bfca53..de10fc0 100644
--- a/overlays/nixpak/firefox.nix
+++ b/overlays/nixpak/firefox.nix
@@ -10,9 +10,12 @@
 
 { cfgPath, ... }: final: prev: {
   firefox-esr = let
-    intermediary-firefox-esr = prev.firefox-esr.override {
-      extraPolicies = import "${cfgPath}/modules/nixos/multimedia/web/firefox/policies.nix";
-      extraPrefs = builtins.trace (import "${cfgPath}/modules/nixos/multimedia/web/firefox/preferences.nix") "";
+    intermediary-firefox-esr = let
+      policiesFile = "${cfgPath}/modules/nixos/multimedia/web/firefox/policies.nix";
+      prefsFile = "${cfgPath}/modules/nixos/multimedia/web/firefox/preferences.nix";
+    in prev.firefox-esr.override {
+      extraPolicies = import policiesFile;
+      extraPrefs = builtins.trace (import prefsFile) (import prefsFile); 
     };
 
     sandboxed-firefox-esr = prev.mkNixPak {