From a69ca3a87d047e268be3fdbab6aebc5b6580ff38 Mon Sep 17 00:00:00 2001
From: caem <caem@dirae.org>
Date: Tue, 14 May 2024 14:52:55 +0200
Subject: [PATCH] Use the .oga extension instead and make sure to include
 metadata

---
 flac2opus_collection.bash | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/flac2opus_collection.bash b/flac2opus_collection.bash
index d959bc4..1fec1aa 100755
--- a/flac2opus_collection.bash
+++ b/flac2opus_collection.bash
@@ -125,7 +125,7 @@ get_total_count() {
     for item in "$dir"/*; do
         if [ -f "$item" ]; then
             new_file="${item/"$INPUT_DIR"/"$OUTPUT_DIR"}"
-            new_file="${new_file/".flac"/".ogg"}"
+            new_file="${new_file/".flac"/".oga"}"
             if [ ! -f "$new_file" ] && [[ "$item" == *".flac" ]]; then
                 ((total_count+=1))
             elif [[ "$item" == *".flac" ]]; then
@@ -159,9 +159,10 @@ iterate_dirs() {
             if [ ! -f "$new_file" ]; then
                 if [[ "$item" == *".flac" ]]; then
                     ((count+=1))
-                    new_file="${new_file/".flac"/".ogg"}"
-                    conversions+=("printf '[%s/%s] \e[92m%s\e[0m -> \e[93m%s\e[0m\n' $count $total_count \
-                        '$item' '$new_file' && ffmpeg -hide_banner -loglevel error -i '$item' -c:a libopus -vbr \"$VBR\" -b:a \"$BITRATE\" '$new_file' > /dev/null")
+                    new_file="${new_file/".flac"/".oga"}"
+                    conversions+=("printf '[%s/%s] \e[92m%s\e[0m -> \e[93m%s\e[0m\n' $count $total_count '$item' '$new_file' && \
+                    ffmpeg -hide_banner -loglevel error -i '$item' -map_metadata 0 -map_metadata 0:s:0 -id3v2_version 3 -c:a libopus \
+                    -vbr \"$VBR\" -b:a \"$BITRATE\" '$new_file' > /dev/null")
                 else
                     new_dir=$(dirname "${item/"$INPUT_DIR"/"$OUTPUT_DIR"}")
                     if [ ! -d "$new_dir" ]; then
@@ -194,6 +195,5 @@ main () {
     iterate_dirs "$INPUT_DIR" "count" "$total_count"
 }
 
-# set -e
 main "$@"