mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 03:40:34 +02:00
Code Activity

Fixed filename-completion-function for readline completion

Browse source 
* guile-readline/readline.c (scm_filename_completion_function):
  A completion function should return #f when there's no more
  candidates.  Since the result of readline's
  rl_filename_completion_function was never checked it was impossible
  for it to work as intended and instead of #f it threw an error from
  trying to convert NULL to an scm string.
This commit is contained in:
Jakub Wojciech 2020-12-20 10:56:51 +01:00 • committed by Daniel Llorens
parent 221203b0df
commit 02439a1240
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
guile-readline/readline.c
View file

@ -386,8 +386,11 @@ SCM_DEFINE (scm_filename_completion_function, "filename-completion-function", 2,
#else #else
s = filename_completion_function (c_text, scm_is_true (continuep)); s = filename_completion_function (c_text, scm_is_true (continuep));
#endif #endif
ans = scm_take_locale_string (s);
free (c_text); free (c_text);
if (!s) {
return SCM_BOOL_F;
}
ans = scm_take_locale_string (s);
return ans; return ans;
} }
#undef FUNC_NAME #undef FUNC_NAME