1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-29 19:30:36 +02:00

Fix asymetric mutex locking when joining thread.

If `join-thread' timeout, the thread mutex is not unlocked, resulting in
deadlock to the next call to it or deadlock of the thread itself when it
terminates.

Thus, always unlock the mutex.

Fixes <https://bugs.gnu.org/55356>.

* module/ice-9/threads.scm (join-thread): Always unlock thread mutex.
* test-suite/tests/threads.test (join-thread): New test to ensure the
mutex is released.
* NEWS: Update.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
This commit is contained in:
Olivier Dion 2024-01-25 16:45:47 -05:00 committed by Ludovic Courtès
parent e791fbcefe
commit 455ee49f55
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
3 changed files with 20 additions and 2 deletions

2
NEWS
View file

@ -37,6 +37,8 @@ the compiler reports it as "possibly unused".
(<https://bugs.gnu.org/64666>)
** Avoid module resolution in 'call-with-new-thread', which could deadlock
(<https://bugs.gnu.org/62691>)
** Fix deadlock in 'join-thread' when timeout is hit
(<https://bugs.gnu.org/55356>)
** 'read-u8' in (scheme base) now defaults to (current-input-port)
(<https://bugs.gnu.org/62690>)
** Hashing of UTF-8 symbols with non-ASCII characters avoids corruption