mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-29 19:30:36 +02:00
Code Activity

fport_print: handle ttyname ENODEV

Browse source 
In some situations, ttyname may return ENODEV even though isatty is
true.  From ttyname(3):

  A process that keeps a file descriptor that refers to a pts(4) device
  open when switching to another mount namespace that uses a different
  /dev/ptmx instance may still accidentally find that a device path of
  the same name for that file descriptor exists.  However, this device
  path refers to a different device and thus can't be used to access the
  device that the file descriptor refers to.  Calling ttyname() or
  ttyname_r() on the file descriptor in the new mount namespace will
  cause these functions to return NULL and set errno to ENODEV.

Observed in a Debian riscv64 porterbox schroot.

When ttyname fails with ENODEV, just include the file descriptor integer
value instead.  Call ttyname() directly to avoid having to catch the
ENODEV.

* libguile/fports.c (fport_print): fall back to the integer fd when
ttyname() fails with ENODEV.
This commit is contained in:
Rob Browning 2025-01-17 11:45:26 -06:00
parent 63756efbc5
commit 48b1c4eff4
2 changed files with 27 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
NEWS
View file

@ -71,6 +71,11 @@ every line in a file.
tag for their type (e.g. ending up tagged as immediates SCM_IMP()).
** `readdir` and `ttyname` now release scm_i_misc_mutex during asyncs
This avoids potential deadlocks.
** Displaying a `port` won't fail when `ttyname` returns ENODEV
`ttyname` may return ENODEV even when the port `isatty()`, and
previously Guile would pass through the related exception. Now it
prints the file descriptor instead (as it does when `ttyname` isn't
available or the port isn't a tty).
Changes in 3.0.10 (since 3.0.9)