mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 11:50:28 +02:00
Code Activity

Avoid throw from critical section, given invalid sigaction call

Browse source 
* libguile/scmsigs.c (scm_sigaction_for_thread): Exit critical section
  before raising out-of-range error.

* test-suite/Makefile.am (SCM_TESTS): Add signals.test.

* test-suite/tests/signals.test: New file.
This commit is contained in:
Neil Jerram 2009-03-05 20:03:33 +00:00
parent 9a84dc8bbc
commit 499c43b032
3 changed files with 34 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libguile/scmsigs.c
View file

@ -356,8 +356,11 @@ SCM_DEFINE (scm_sigaction_for_thread, "sigaction", 1, 3, 0,
install_handler (csig, SCM_BOOL_F, SCM_BOOL_F, async); install_handler (csig, SCM_BOOL_F, SCM_BOOL_F, async);
} }
else else
{
SCM_CRITICAL_SECTION_END;
SCM_OUT_OF_RANGE (2, handler); SCM_OUT_OF_RANGE (2, handler);
} }
}
else if (scm_is_false (handler)) else if (scm_is_false (handler))
{ {
/* restore the default handler. */ /* restore the default handler. */

1
test-suite/Makefile.am
View file

@ -64,6 +64,7 @@ SCM_TESTS = tests/alist.test \
tests/reader.test \ tests/reader.test \
tests/receive.test \ tests/receive.test \
tests/regexp.test \ tests/regexp.test \
tests/signals.test \
tests/socket.test \ tests/socket.test \
tests/srcprop.test \ tests/srcprop.test \
tests/srfi-1.test \ tests/srfi-1.test \

29
test-suite/tests/signals.test Normal file
View file

@ -0,0 +1,29 @@
;;;; signals.test --- test suite for Guile's signal functions -*- scheme -*-
;;;;
;;;; Copyright (C) 2009 Free Software Foundation, Inc.
;;;;
;;;; This program is free software; you can redistribute it and/or modify
;;;; it under the terms of the GNU General Public License as published by
;;;; the Free Software Foundation; either version 2, or (at your option)
;;;; any later version.
;;;;
;;;; This program is distributed in the hope that it will be useful,
;;;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;;;; GNU General Public License for more details.
;;;;
;;;; You should have received a copy of the GNU General Public License
;;;; along with this software; see the file COPYING. If not, write to
;;;; the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
;;;; Boston, MA 02110-1301 USA
(use-modules (test-suite lib))
(with-test-prefix "sigaction"
(pass-if-exception "handler arg is an invalid integer"
exception:out-of-range
(sigaction SIGINT 51))
)