mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 19:50:24 +02:00
Code Activity

make-chunked-output-port buffering fix

Browse source 
* module/web/http.scm (make-chunked-output-port): Add #:buffering
  argument, defaulting to 1200 (some random value under the MTU).  This
  will force a flush every so often, and not every character as would
  otherwise be the case after this port rewrite.
This commit is contained in:
Andy Wingo 2016-04-11 22:22:39 +02:00
parent 3ce52fa503
commit 55fb8f4e7e
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
module/web/http.scm
View file

@ -1972,13 +1972,15 @@ closed it will also close PORT, unless the KEEP-ALIVE? is true."
(loop to-read 0)) (loop to-read 0))
(make-custom-binary-input-port "chunked input port" read! #f #f close)) (make-custom-binary-input-port "chunked input port" read! #f #f close))
(define* (make-chunked-output-port port #:key (keep-alive? #f)) (define* (make-chunked-output-port port #:key (keep-alive? #f)
(buffering 1200))
"Returns a new port which translates non-encoded data into a HTTP "Returns a new port which translates non-encoded data into a HTTP
chunked transfer encoded data and writes this to PORT. Data chunked transfer encoded data and writes this to PORT. Data written to
written to this port is buffered until the port is flushed, at which this port is buffered until the port is flushed, at which point it is
point it is all sent as one chunk. Take care to close the port when all sent as one chunk. The port will otherwise be flushed every
done, as it will output the remaining data, and encode the final zero BUFFERING bytes, which defaults to 1200. Take care to close the port
chunk. When the port is closed it will also close PORT, unless when done, as it will output the remaining data, and encode the final
zero chunk. When the port is closed it will also close PORT, unless
KEEP-ALIVE? is true." KEEP-ALIVE? is true."
(define (q-for-each f q) (define (q-for-each f q)
(while (not (q-empty? q)) (while (not (q-empty? q))
@ -2005,7 +2007,9 @@ KEEP-ALIVE? is true."
(force-output port) (force-output port)
(unless keep-alive? (unless keep-alive?
(close-port port))) (close-port port)))
(make-soft-port (vector put-char put-string flush #f close) "w")) (let ((ret (make-soft-port (vector put-char put-string flush #f close) "w")))
(setvbuf ret 'block buffering)
ret))
(define %http-proxy-port? (make-object-property)) (define %http-proxy-port? (make-object-property))
(define (http-proxy-port? port) (%http-proxy-port? port)) (define (http-proxy-port? port) (%http-proxy-port? port))