1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 03:40:34 +02:00

psyntax: Factor module-variable use to helpers

* module/ice-9/psyntax.scm (resolve-module*, resolve-variable): New
helpers.
(free-id=?, resolve-identifier): Use new helpers.
* module/ice-9/psyntax-pp.scm: Regenerate.
This commit is contained in:
Andy Wingo 2024-11-19 11:29:39 +01:00
parent 5ddb366375
commit 7379049d30
2 changed files with 156 additions and 78 deletions

View file

@ -46,6 +46,63 @@
(lambda-src (lambda (x) (struct-ref x 0))) (lambda-src (lambda (x) (struct-ref x 0)))
(lambda-meta (lambda (x) (struct-ref x 1))) (lambda-meta (lambda (x) (struct-ref x 1)))
(lambda-body (lambda (x) (struct-ref x 2))) (lambda-body (lambda (x) (struct-ref x 2)))
(resolve-module*
(lambda (mod)
(let* ((v mod)
(fk (lambda ()
(let ((fk (lambda ()
(let ((fk (lambda ()
(let ((fk (lambda () (error "value failed to match" v))))
(if (pair? v)
(let ((vx (car v)) (vy (cdr v)))
(let ((tk (lambda ()
(let ((mod vy))
(resolve-module mod #:ensure #f)))))
(if (eq? vx 'private)
(tk)
(let ((tk (lambda () (tk))))
(if (eq? vx 'hygiene) (tk) (fk))))))
(fk))))))
(if (pair? v)
(let ((vx (car v)) (vy (cdr v)))
(if (eq? vx 'public)
(let* ((mod vy)
(v (resolve-module mod #:ensure #f))
(fk (lambda ()
(let* ((fk (lambda ()
(error "value failed to match" v)))
(mod v))
(module-public-interface mod)))))
(if (eq? v #f) #f (fk)))
(fk)))
(fk))))))
(if (pair? v)
(let ((vx (car v)) (vy (cdr v)))
(if (eq? vx 'primitive) (if (null? vy) #f (fk)) (fk)))
(fk))))))
(if (eq? v #f) (current-module) (fk)))))
(resolve-variable
(lambda (mod var)
(let* ((v (resolve-module* mod))
(fk (lambda ()
(let* ((fk (lambda () (error "value failed to match" v))) (mod v))
(module-variable mod var)))))
(if (eq? v #f)
(let* ((v (current-module))
(fk (lambda () (let ((fk (lambda () (error "value failed to match" v)))) #f))))
(if (eq? v #f)
(let* ((v mod) (fk (lambda () (error "value failed to match" v))))
(if (pair? v)
(let ((vx (car v)) (vy (cdr v)))
(if (eq? vx 'hygiene)
(if (pair? vy)
(let ((vx (car vy)) (vy (cdr vy)))
(if (eq? vx 'guile) (if (null? vy) (module-variable #f var) (fk)) (fk)))
(fk))
(fk)))
(fk)))
(fk)))
(fk)))))
(top-level-eval (lambda (x mod) (primitive-eval x))) (top-level-eval (lambda (x mod) (primitive-eval x)))
(local-eval (lambda (x mod) (primitive-eval x))) (local-eval (lambda (x mod) (primitive-eval x)))
(sourcev-filename (lambda (s) (vector-ref s 0))) (sourcev-filename (lambda (s) (vector-ref s 0)))
@ -575,8 +632,7 @@
(lambda (var mod) (lambda (var mod)
(if (and (not mod) (current-module)) (if (and (not mod) (current-module))
(warn "module system is booted, we should have a module" var)) (warn "module system is booted, we should have a module" var))
(let ((v (and (not (equal? mod '(primitive))) (let ((v (resolve-variable mod var)))
(module-variable (if mod (resolve-module (cdr mod)) (current-module)) var))))
(if (and v (variable-bound? v) (macro? (variable-ref v))) (if (and v (variable-bound? v) (macro? (variable-ref v)))
(let* ((m (variable-ref v)) (type (macro-type m)) (trans (macro-binding m))) (let* ((m (variable-ref v)) (type (macro-type m)) (trans (macro-binding m)))
(if (eq? type 'syntax-parameter) (if (eq? type 'syntax-parameter)
@ -619,9 +675,7 @@
(mj (and (syntax? j) (syntax-module j))) (mj (and (syntax? j) (syntax-module j)))
(ni (id-var-name i empty-wrap mi)) (ni (id-var-name i empty-wrap mi))
(nj (id-var-name j empty-wrap mj))) (nj (id-var-name j empty-wrap mj)))
(letrec* ((id-module-binding (letrec* ((id-module-binding (lambda (id mod) (resolve-variable mod (id-sym-name id)))))
(lambda (id mod)
(module-variable (if mod (resolve-module (cdr mod)) (current-module)) (id-sym-name id)))))
(cond (cond
((syntax? ni) (free-id=? ni j)) ((syntax? ni) (free-id=? ni j))
((syntax? nj) (free-id=? i nj)) ((syntax? nj) (free-id=? i nj))
@ -1146,11 +1200,11 @@
(source-wrap e w (wrap-subst w) mod) (source-wrap e w (wrap-subst w) mod)
x)) x))
(else (decorate-source x)))))) (else (decorate-source x))))))
(let* ((t-680b775fb37a463-c47 transformer-environment) (let* ((t-680b775fb37a463-cc2 transformer-environment)
(t-680b775fb37a463-c48 (lambda (k) (k e r w s rib mod)))) (t-680b775fb37a463-cc3 (lambda (k) (k e r w s rib mod))))
(with-fluid* (with-fluid*
t-680b775fb37a463-c47 t-680b775fb37a463-cc2
t-680b775fb37a463-c48 t-680b775fb37a463-cc3
(lambda () (rebuild-macro-output (p (source-wrap e (anti-mark w) s mod)) (new-mark)))))))) (lambda () (rebuild-macro-output (p (source-wrap e (anti-mark w) s mod)) (new-mark))))))))
(expand-body (expand-body
(lambda (body outer-form r w mod) (lambda (body outer-form r w mod)
@ -1681,11 +1735,11 @@
s s
mod mod
get-formals get-formals
(map (lambda (tmp-680b775fb37a463-ed0 (map (lambda (tmp-680b775fb37a463-f4b
tmp-680b775fb37a463-ecf tmp-680b775fb37a463-f4a
tmp-680b775fb37a463-ece) tmp-680b775fb37a463-f49)
(cons tmp-680b775fb37a463-ece (cons tmp-680b775fb37a463-f49
(cons tmp-680b775fb37a463-ecf tmp-680b775fb37a463-ed0))) (cons tmp-680b775fb37a463-f4a tmp-680b775fb37a463-f4b)))
e2* e2*
e1* e1*
args*))) args*)))
@ -1958,8 +2012,11 @@
(apply (lambda (args e1 e2) (apply (lambda (args e1 e2)
(build-it (build-it
'() '()
(map (lambda (tmp-680b775fb37a463-2 tmp-680b775fb37a463-1 tmp-680b775fb37a463) (map (lambda (tmp-680b775fb37a463-11b0
(cons tmp-680b775fb37a463 (cons tmp-680b775fb37a463-1 tmp-680b775fb37a463-2))) tmp-680b775fb37a463-11af
tmp-680b775fb37a463-11ae)
(cons tmp-680b775fb37a463-11ae
(cons tmp-680b775fb37a463-11af tmp-680b775fb37a463-11b0)))
e2 e2
e1 e1
args))) args)))
@ -1969,11 +2026,11 @@
(apply (lambda (docstring args e1 e2) (apply (lambda (docstring args e1 e2)
(build-it (build-it
(list (cons 'documentation (syntax->datum docstring))) (list (cons 'documentation (syntax->datum docstring)))
(map (lambda (tmp-680b775fb37a463-114b (map (lambda (tmp-680b775fb37a463-11c6
tmp-680b775fb37a463-114a tmp-680b775fb37a463-11c5
tmp-680b775fb37a463) tmp-680b775fb37a463-11c4)
(cons tmp-680b775fb37a463 (cons tmp-680b775fb37a463-11c4
(cons tmp-680b775fb37a463-114a tmp-680b775fb37a463-114b))) (cons tmp-680b775fb37a463-11c5 tmp-680b775fb37a463-11c6)))
e2 e2
e1 e1
args))) args)))
@ -1991,9 +2048,11 @@
(apply (lambda (args e1 e2) (apply (lambda (args e1 e2)
(build-it (build-it
'() '()
(map (lambda (tmp-680b775fb37a463-116b tmp-680b775fb37a463-116a tmp-680b775fb37a463) (map (lambda (tmp-680b775fb37a463-11e6
(cons tmp-680b775fb37a463 tmp-680b775fb37a463-11e5
(cons tmp-680b775fb37a463-116a tmp-680b775fb37a463-116b))) tmp-680b775fb37a463-11e4)
(cons tmp-680b775fb37a463-11e4
(cons tmp-680b775fb37a463-11e5 tmp-680b775fb37a463-11e6)))
e2 e2
e1 e1
args))) args)))
@ -2003,9 +2062,11 @@
(apply (lambda (docstring args e1 e2) (apply (lambda (docstring args e1 e2)
(build-it (build-it
(list (cons 'documentation (syntax->datum docstring))) (list (cons 'documentation (syntax->datum docstring)))
(map (lambda (tmp-680b775fb37a463-1 tmp-680b775fb37a463 tmp-680b775fb37a463-117f) (map (lambda (tmp-680b775fb37a463-11fc
(cons tmp-680b775fb37a463-117f tmp-680b775fb37a463-11fb
(cons tmp-680b775fb37a463 tmp-680b775fb37a463-1))) tmp-680b775fb37a463-11fa)
(cons tmp-680b775fb37a463-11fa
(cons tmp-680b775fb37a463-11fb tmp-680b775fb37a463-11fc)))
e2 e2
e1 e1
args))) args)))
@ -2815,9 +2876,9 @@
#f #f
k k
'() '()
(map (lambda (tmp-680b775fb37a463-145f tmp-680b775fb37a463-145e tmp-680b775fb37a463-145d) (map (lambda (tmp-680b775fb37a463-14da tmp-680b775fb37a463-14d9 tmp-680b775fb37a463-14d8)
(list (cons tmp-680b775fb37a463-145d tmp-680b775fb37a463-145e) (list (cons tmp-680b775fb37a463-14d8 tmp-680b775fb37a463-14d9)
tmp-680b775fb37a463-145f)) tmp-680b775fb37a463-14da))
template template
pattern pattern
keyword))) keyword)))
@ -2832,8 +2893,11 @@
#f #f
k k
(list docstring) (list docstring)
(map (lambda (tmp-680b775fb37a463-2 tmp-680b775fb37a463-1 tmp-680b775fb37a463) (map (lambda (tmp-680b775fb37a463-14f3
(list (cons tmp-680b775fb37a463 tmp-680b775fb37a463-1) tmp-680b775fb37a463-2)) tmp-680b775fb37a463-14f2
tmp-680b775fb37a463-14f1)
(list (cons tmp-680b775fb37a463-14f1 tmp-680b775fb37a463-14f2)
tmp-680b775fb37a463-14f3))
template template
pattern pattern
keyword))) keyword)))
@ -2845,9 +2909,11 @@
dots dots
k k
'() '()
(map (lambda (tmp-680b775fb37a463-1 tmp-680b775fb37a463 tmp-680b775fb37a463-148f) (map (lambda (tmp-680b775fb37a463-150c
(list (cons tmp-680b775fb37a463-148f tmp-680b775fb37a463) tmp-680b775fb37a463-150b
tmp-680b775fb37a463-1)) tmp-680b775fb37a463-150a)
(list (cons tmp-680b775fb37a463-150a tmp-680b775fb37a463-150b)
tmp-680b775fb37a463-150c))
template template
pattern pattern
keyword))) keyword)))
@ -2863,11 +2929,11 @@
dots dots
k k
(list docstring) (list docstring)
(map (lambda (tmp-680b775fb37a463-14b0 (map (lambda (tmp-680b775fb37a463-152b
tmp-680b775fb37a463-14af tmp-680b775fb37a463-152a
tmp-680b775fb37a463-14ae) tmp-680b775fb37a463)
(list (cons tmp-680b775fb37a463-14ae tmp-680b775fb37a463-14af) (list (cons tmp-680b775fb37a463 tmp-680b775fb37a463-152a)
tmp-680b775fb37a463-14b0)) tmp-680b775fb37a463-152b))
template template
pattern pattern
keyword))) keyword)))
@ -2995,9 +3061,9 @@
(apply (lambda (p) (apply (lambda (p)
(if (= lev 0) (if (= lev 0)
(quasilist* (quasilist*
(map (lambda (tmp-680b775fb37a463-155d) (map (lambda (tmp-680b775fb37a463-15d8)
(list "value" (list "value"
tmp-680b775fb37a463-155d)) tmp-680b775fb37a463-15d8))
p) p)
(quasi q lev)) (quasi q lev))
(quasicons (quasicons
@ -3023,9 +3089,9 @@
(apply (lambda (p) (apply (lambda (p)
(if (= lev 0) (if (= lev 0)
(quasiappend (quasiappend
(map (lambda (tmp-680b775fb37a463) (map (lambda (tmp-680b775fb37a463-15dd)
(list "value" (list "value"
tmp-680b775fb37a463)) tmp-680b775fb37a463-15dd))
p) p)
(quasi q lev)) (quasi q lev))
(quasicons (quasicons
@ -3061,8 +3127,8 @@
(apply (lambda (p) (apply (lambda (p)
(if (= lev 0) (if (= lev 0)
(quasilist* (quasilist*
(map (lambda (tmp-680b775fb37a463) (map (lambda (tmp-680b775fb37a463-15f3)
(list "value" tmp-680b775fb37a463)) (list "value" tmp-680b775fb37a463-15f3))
p) p)
(vquasi q lev)) (vquasi q lev))
(quasicons (quasicons
@ -3082,8 +3148,8 @@
(apply (lambda (p) (apply (lambda (p)
(if (= lev 0) (if (= lev 0)
(quasiappend (quasiappend
(map (lambda (tmp-680b775fb37a463-157d) (map (lambda (tmp-680b775fb37a463-15f8)
(list "value" tmp-680b775fb37a463-157d)) (list "value" tmp-680b775fb37a463-15f8))
p) p)
(vquasi q lev)) (vquasi q lev))
(quasicons (quasicons
@ -3165,8 +3231,7 @@
(let ((tmp-1 ls)) (let ((tmp-1 ls))
(let ((tmp ($sc-dispatch tmp-1 'each-any))) (let ((tmp ($sc-dispatch tmp-1 'each-any)))
(if tmp (if tmp
(apply (lambda (t-680b775fb37a463-15c6) (apply (lambda (t-680b775fb37a463) (cons "vector" t-680b775fb37a463))
(cons "vector" t-680b775fb37a463-15c6))
tmp) tmp)
(syntax-violation (syntax-violation
#f #f
@ -3176,8 +3241,8 @@
(let ((tmp-1 ($sc-dispatch tmp '(#(atom "quote") each-any)))) (let ((tmp-1 ($sc-dispatch tmp '(#(atom "quote") each-any))))
(if tmp-1 (if tmp-1
(apply (lambda (y) (apply (lambda (y)
(k (map (lambda (tmp-680b775fb37a463-15d2) (k (map (lambda (tmp-680b775fb37a463-164d)
(list "quote" tmp-680b775fb37a463-15d2)) (list "quote" tmp-680b775fb37a463-164d))
y))) y)))
tmp-1) tmp-1)
(let ((tmp-1 ($sc-dispatch tmp '(#(atom "list") . each-any)))) (let ((tmp-1 ($sc-dispatch tmp '(#(atom "list") . each-any))))
@ -3188,8 +3253,8 @@
(apply (lambda (y z) (f z (lambda (ls) (k (append y ls))))) tmp-1) (apply (lambda (y z) (f z (lambda (ls) (k (append y ls))))) tmp-1)
(let ((else tmp)) (let ((else tmp))
(let ((tmp x)) (let ((tmp x))
(let ((t-680b775fb37a463-15e1 tmp)) (let ((t-680b775fb37a463-165c tmp))
(list "list->vector" t-680b775fb37a463-15e1))))))))))))))))) (list "list->vector" t-680b775fb37a463-165c)))))))))))))))))
(emit (lambda (x) (emit (lambda (x)
(let ((tmp x)) (let ((tmp x))
(let ((tmp-1 ($sc-dispatch tmp '(#(atom "quote") any)))) (let ((tmp-1 ($sc-dispatch tmp '(#(atom "quote") any))))
@ -3201,9 +3266,9 @@
(let ((tmp-1 (map emit x))) (let ((tmp-1 (map emit x)))
(let ((tmp ($sc-dispatch tmp-1 'each-any))) (let ((tmp ($sc-dispatch tmp-1 'each-any)))
(if tmp (if tmp
(apply (lambda (t-680b775fb37a463-15f0) (apply (lambda (t-680b775fb37a463-166b)
(cons (make-syntax 'list '((top)) '(hygiene guile)) (cons (make-syntax 'list '((top)) '(hygiene guile))
t-680b775fb37a463-15f0)) t-680b775fb37a463-166b))
tmp) tmp)
(syntax-violation (syntax-violation
#f #f
@ -3219,13 +3284,14 @@
(let ((tmp-1 (list (emit (car x*)) (f (cdr x*))))) (let ((tmp-1 (list (emit (car x*)) (f (cdr x*)))))
(let ((tmp ($sc-dispatch tmp-1 '(any any)))) (let ((tmp ($sc-dispatch tmp-1 '(any any))))
(if tmp (if tmp
(apply (lambda (t-680b775fb37a463-1 t-680b775fb37a463) (apply (lambda (t-680b775fb37a463-167f
t-680b775fb37a463-167e)
(list (make-syntax (list (make-syntax
'cons 'cons
'((top)) '((top))
'(hygiene guile)) '(hygiene guile))
t-680b775fb37a463-1 t-680b775fb37a463-167f
t-680b775fb37a463)) t-680b775fb37a463-167e))
tmp) tmp)
(syntax-violation (syntax-violation
#f #f
@ -3238,12 +3304,12 @@
(let ((tmp-1 (map emit x))) (let ((tmp-1 (map emit x)))
(let ((tmp ($sc-dispatch tmp-1 'each-any))) (let ((tmp ($sc-dispatch tmp-1 'each-any)))
(if tmp (if tmp
(apply (lambda (t-680b775fb37a463) (apply (lambda (t-680b775fb37a463-168b)
(cons (make-syntax (cons (make-syntax
'append 'append
'((top)) '((top))
'(hygiene guile)) '(hygiene guile))
t-680b775fb37a463)) t-680b775fb37a463-168b))
tmp) tmp)
(syntax-violation (syntax-violation
#f #f
@ -3256,12 +3322,12 @@
(let ((tmp-1 (map emit x))) (let ((tmp-1 (map emit x)))
(let ((tmp ($sc-dispatch tmp-1 'each-any))) (let ((tmp ($sc-dispatch tmp-1 'each-any)))
(if tmp (if tmp
(apply (lambda (t-680b775fb37a463-161c) (apply (lambda (t-680b775fb37a463)
(cons (make-syntax (cons (make-syntax
'vector 'vector
'((top)) '((top))
'(hygiene guile)) '(hygiene guile))
t-680b775fb37a463-161c)) t-680b775fb37a463))
tmp) tmp)
(syntax-violation (syntax-violation
#f #f
@ -3272,12 +3338,12 @@
(if tmp-1 (if tmp-1
(apply (lambda (x) (apply (lambda (x)
(let ((tmp (emit x))) (let ((tmp (emit x)))
(let ((t-680b775fb37a463 tmp)) (let ((t-680b775fb37a463-16a3 tmp))
(list (make-syntax (list (make-syntax
'list->vector 'list->vector
'((top)) '((top))
'(hygiene guile)) '(hygiene guile))
t-680b775fb37a463)))) t-680b775fb37a463-16a3))))
tmp-1) tmp-1)
(let ((tmp-1 ($sc-dispatch tmp '(#(atom "value") any)))) (let ((tmp-1 ($sc-dispatch tmp '(#(atom "value") any))))
(if tmp-1 (if tmp-1

View file

@ -178,6 +178,29 @@
(define-syntax-rule (match e cs ...) (simple-match e cs ...)) (define-syntax-rule (match e cs ...) (simple-match e cs ...))
(define (resolve-module* mod)
(match mod
(#f (current-module))
(('primitive) #f)
(('public . mod)
;; Defer possibly-failed binding of (@ (unknown-module) id) until
;; run-time.
(match (resolve-module mod #:ensure #f)
(#f #f)
(mod (module-public-interface mod))))
(((or 'private 'hygiene) . mod)
(resolve-module mod #:ensure #f))))
(define (resolve-variable mod var)
(match (resolve-module* mod)
(#f (match (current-module)
(#f
;; Module system not yet booted.
(match mod
(('hygiene 'guile) (module-variable #f var))))
(_ #f)))
(mod (module-variable mod var))))
(define (top-level-eval x mod) (define (top-level-eval x mod)
(primitive-eval x)) (primitive-eval x))
@ -743,11 +766,7 @@
(define (resolve-global var mod) (define (resolve-global var mod)
(when (and (not mod) (current-module)) (when (and (not mod) (current-module))
(warn "module system is booted, we should have a module" var)) (warn "module system is booted, we should have a module" var))
(let ((v (and (not (equal? mod '(primitive))) (let ((v (resolve-variable mod var)))
(module-variable (if mod
(resolve-module (cdr mod))
(current-module))
var))))
;; The expander needs to know when a top-level definition from ;; The expander needs to know when a top-level definition from
;; outside the compilation unit is a macro. ;; outside the compilation unit is a macro.
;; ;;
@ -848,14 +867,7 @@
(ni (id-var-name i empty-wrap mi)) (ni (id-var-name i empty-wrap mi))
(nj (id-var-name j empty-wrap mj))) (nj (id-var-name j empty-wrap mj)))
(define (id-module-binding id mod) (define (id-module-binding id mod)
(module-variable (resolve-variable mod (id-sym-name id)))
(if mod
;; The normal case.
(resolve-module (cdr mod))
;; Either modules have not been booted, or we have a
;; raw symbol coming in, which is possible.
(current-module))
(id-sym-name id)))
(cond (cond
((syntax? ni) (free-id=? ni j)) ((syntax? ni) (free-id=? ni j))
((syntax? nj) (free-id=? i nj)) ((syntax? nj) (free-id=? i nj))