mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 19:50:24 +02:00
Code Activity

Avoid calling `u32_conv_from_encoding' on the null string

Browse source 
* libguile/strings.c (scm_from_stringn): Avoid calling
  `u32_conv_from_encoding' on the null string, by using the same
  fast-path code used if (encoding == NULL).  This is an optimization,
  and also avoids any possible encoding errors.
This commit is contained in:
Mark H Weaver 2012-01-10 06:18:31 -05:00
parent 3248c954db
commit 7532125912
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libguile/strings.c
View file

@ -1473,9 +1473,9 @@ scm_from_stringn (const char *str, size_t len, const char *encoding,
if (len == (size_t) -1) if (len == (size_t) -1)
len = strlen (str); len = strlen (str);
if (encoding == NULL) if (encoding == NULL || len == 0)
{ {
/* If encoding is null, use Latin-1. */ /* If encoding is null (or the string is empty), use Latin-1. */
char *buf; char *buf;
res = scm_i_make_string (len, &buf, 0); res = scm_i_make_string (len, &buf, 0);
memcpy (buf, str, len); memcpy (buf, str, len);