mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-09 13:30:26 +02:00
Code Activity

Initial live mask does not include young allocations

Browse source 
After rotation, the young bit wasn't being included anyway.  This just
improves the first collection.
This commit is contained in:
Andy Wingo 2022-08-02 13:57:15 +02:00
parent 1781c5aed4
commit 7f405c929e
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
whippet.h
View file

@ -1264,10 +1264,9 @@ static void collect(struct mutator *mut, enum gc_reason reason) {
static int sweep_byte(uint8_t *loc, uintptr_t sweep_mask) { static int sweep_byte(uint8_t *loc, uintptr_t sweep_mask) {
uint8_t metadata = atomic_load_explicit(loc, memory_order_relaxed); uint8_t metadata = atomic_load_explicit(loc, memory_order_relaxed);
// If the metadata byte is nonzero, that means either a young, dead, // If the metadata byte is nonzero, that means either a young, dead,
// survived, or marked object. If it's live (young, survived, or // survived, or marked object. If it's live (survived or marked), we
// marked), we found the next mark. Otherwise it's dead and we clear // found the next mark. Otherwise it's dead and we clear the byte.
// the byte. If we see an END, that means an end of a dead object; // If we see an END, that means an end of a dead object; clear it.
// clear it.
if (metadata) { if (metadata) {
if (metadata & sweep_mask) if (metadata & sweep_mask)
return 1; return 1;
@ -1715,7 +1714,7 @@ static int mark_space_init(struct mark_space *space, struct heap *heap) {
uint8_t survived = METADATA_BYTE_MARK_1; uint8_t survived = METADATA_BYTE_MARK_1;
uint8_t marked = METADATA_BYTE_MARK_2; uint8_t marked = METADATA_BYTE_MARK_2;
space->marked_mask = marked; space->marked_mask = marked;
space->live_mask = METADATA_BYTE_YOUNG | survived | marked; space->live_mask = survived | marked;
rotate_mark_bytes(space); rotate_mark_bytes(space);
space->slabs = slabs; space->slabs = slabs;
space->nslabs = nslabs; space->nslabs = nslabs;