diff --git a/libguile/async.h b/libguile/async.h index 427d9b4c8..b9b795f4f 100644 --- a/libguile/async.h +++ b/libguile/async.h @@ -60,20 +60,18 @@ void scm_dynwind_unblock_asyncs (void); the manual. */ -/* Defined in threads.c. scm_i_critical_section_level is only used - for error checking and will go away eventually. */ +/* Defined in threads.c. */ extern scm_i_pthread_mutex_t scm_i_critical_section_mutex; -extern int scm_i_critical_section_level; #define SCM_CRITICAL_SECTION_START \ do { \ scm_i_pthread_mutex_lock (&scm_i_critical_section_mutex);\ SCM_I_CURRENT_THREAD->block_asyncs++; \ - scm_i_critical_section_level++; \ + SCM_I_CURRENT_THREAD->critical_section_level++; \ } while (0) #define SCM_CRITICAL_SECTION_END \ do { \ - scm_i_critical_section_level--; \ + SCM_I_CURRENT_THREAD->critical_section_level--; \ SCM_I_CURRENT_THREAD->block_asyncs--; \ scm_i_pthread_mutex_unlock (&scm_i_critical_section_mutex); \ scm_async_click (); \ diff --git a/libguile/continuations.c b/libguile/continuations.c index aa1fb334e..a0e2f6d4f 100644 --- a/libguile/continuations.c +++ b/libguile/continuations.c @@ -225,7 +225,7 @@ scm_dynthrow (SCM cont, SCM val) SCM_STACKITEM *dst = thread->continuation_base; SCM_STACKITEM stack_top_element; - if (scm_i_critical_section_level) + if (thread->critical_section_level) { fprintf (stderr, "continuation invoked from within critical section.\n"); abort (); diff --git a/libguile/threads.c b/libguile/threads.c index 8dce6043c..901695cfe 100644 --- a/libguile/threads.c +++ b/libguile/threads.c @@ -318,6 +318,7 @@ guilify_self_1 (SCM_STACKITEM *base) t->active_asyncs = SCM_EOL; t->block_asyncs = 1; t->pending_asyncs = 1; + t->critical_section_level = 0; t->last_debug_frame = NULL; t->base = base; #ifdef __ia64__ @@ -1855,7 +1856,6 @@ static int threads_initialized_p = 0; /* This mutex is used by SCM_CRITICAL_SECTION_START/END. */ scm_i_pthread_mutex_t scm_i_critical_section_mutex; -int scm_i_critical_section_level = 0; static SCM dynwind_critical_section_mutex; diff --git a/libguile/threads.h b/libguile/threads.h index 55102df17..842f0d9d0 100644 --- a/libguile/threads.h +++ b/libguile/threads.h @@ -117,6 +117,9 @@ typedef struct scm_i_thread { scm_t_contregs *pending_rbs_continuation; #endif + /* Whether this thread is in a critical section. */ + int critical_section_level; + } scm_i_thread; #define SCM_I_IS_THREAD(x) SCM_SMOB_PREDICATE (scm_tc16_thread, x) diff --git a/libguile/throw.c b/libguile/throw.c index cf6ea4a49..07d215f41 100644 --- a/libguile/throw.c +++ b/libguile/throw.c @@ -732,7 +732,7 @@ scm_ithrow (SCM key, SCM args, int noreturn SCM_UNUSED) SCM dynpair = SCM_UNDEFINED; SCM winds; - if (scm_i_critical_section_level) + if (SCM_I_CURRENT_THREAD->critical_section_level) { SCM s = args; int i = 0;