mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 19:50:24 +02:00
Code Activity

Remove use of `scm_i_thread_put_to_sleep ()' in the string code.

Browse source 
* libguile/strings.c (scm_i_string_writable_chars): Remove use of
  `scm_i_thread_put_to_sleep ()'.  This leaves a race condition,
  which is hopefully not harmful.
This commit is contained in:
Ludovic Courtès 2008-09-17 20:41:41 +02:00
parent 8b039053b8
commit 902578f15a
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
libguile/strings.c
View file

@ -325,8 +325,7 @@ scm_i_string_writable_chars (SCM orig_str)
scm_i_pthread_mutex_lock (&stringbuf_write_mutex); scm_i_pthread_mutex_lock (&stringbuf_write_mutex);
if (STRINGBUF_SHARED (buf)) if (STRINGBUF_SHARED (buf))
{ {
/* Clone stringbuf. For this, we put all threads to sleep. /* Clone stringbuf. */
*/
size_t len = STRING_LENGTH (str); size_t len = STRING_LENGTH (str);
SCM new_buf; SCM new_buf;
@ -337,11 +336,16 @@ scm_i_string_writable_chars (SCM orig_str)
memcpy (STRINGBUF_CHARS (new_buf), memcpy (STRINGBUF_CHARS (new_buf),
STRINGBUF_CHARS (buf) + STRING_START (str), len); STRINGBUF_CHARS (buf) + STRING_START (str), len);
scm_i_thread_put_to_sleep ();
SET_STRING_STRINGBUF (str, new_buf);
start -= STRING_START (str); start -= STRING_START (str);
/* FIXME: The following operations are not atomic, so other threads
looking at STR may see an inconsistent state. Nevertheless it can't
hurt much since (i) accessing STR while it is being mutated can't
yield a crash, and (ii) concurrent accesses to STR should be
protected by a mutex at the application level. The latter may not
apply when STR != ORIG_STR, though. */
SET_STRING_START (str, 0); SET_STRING_START (str, 0);
scm_i_thread_wake_up (); SET_STRING_STRINGBUF (str, new_buf);
buf = new_buf; buf = new_buf;