futures: Store pending futures in a queue.

* module/ice-9/futures.scm (%futures): Change from a list to a queue.
  (register-future!, process-futures, touch): Adjust accordingly.
  (unregister-future!): Remove.

module/ice-9/futures.scm

@@ -19,7 +19,7 @@
 (define-module (ice-9 futures)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-9)
-  #:use-module (ice-9 match)
+  #:use-module (ice-9 q)
   #:export (future make-future future? touch))
 
 ;;; Author: Ludovic Courtès <ludo@gnu.org>
@@ -63,21 +63,17 @@ touched."
 ;;; Future queues.
 ;;;
 
-(define %futures '())
+(define %futures (make-q))
 (define %futures-mutex (make-mutex))
 (define %futures-available (make-condition-variable))
 
 (define (register-future! future)
   ;; Register FUTURE as being processable.
   (lock-mutex %futures-mutex)
-  (set! %futures (cons future %futures)) ;; FIXME: use a FIFO
+  (enq! %futures future)
   (signal-condition-variable %futures-available)
   (unlock-mutex %futures-mutex))
 
-(define (unregister-future! future)
-  ;; Assume %FUTURES-MUTEX is taken.
-  (set! %futures (delq future %futures)))
-
 (define (process-future! future)
   ;; Process FUTURE, assuming its mutex is already taken.
   (set-future-result! future
@@ -98,29 +94,27 @@ touched."
   (let loop ()
     (wait-condition-variable %futures-available
                              %futures-mutex)
-    (match %futures
+    (or (q-empty? %futures)
-      (() (loop))
+        (let ((future (deq! %futures)))
-      ((future _ ...)
+          (lock-mutex (future-mutex future))
-       (lock-mutex (future-mutex future))
+          (or (and (future-done? future)
-       (or (and (future-done? future)
+                   (unlock-mutex (future-mutex future)))
-                (unlock-mutex (future-mutex future)))
+              (begin
-           (begin
+                ;; Do the actual work.
-             ;; Do the actual work.
-             (unregister-future! future)
 
-             ;; We want to release %FUTURES-MUTEX so that other workers
+                ;; We want to release %FUTURES-MUTEX so that other workers
-             ;; can progress.  However, to avoid deadlocks, we have to
+                ;; can progress.  However, to avoid deadlocks, we have to
-             ;; unlock FUTURE as well, to preserve lock ordering.
+                ;; unlock FUTURE as well, to preserve lock ordering.
-             (unlock-mutex (future-mutex future))
+                (unlock-mutex (future-mutex future))
-             (unlock-mutex %futures-mutex)
+                (unlock-mutex %futures-mutex)
 
-             (lock-mutex (future-mutex future))
+                (lock-mutex (future-mutex future))
-             (or (future-done? future)            ; lost the race?
+                (or (future-done? future)            ; lost the race?
-                 (process-future! future))
+                    (process-future! future))
-             (unlock-mutex (future-mutex future))
+                (unlock-mutex (future-mutex future))
 
-             (lock-mutex %futures-mutex)))
+                (lock-mutex %futures-mutex)))))
-       (loop)))))
+    (loop)))
 
 (define (touch future)
   "Return the result of FUTURE, computing it if not already done."
@@ -132,7 +126,7 @@ touched."
         (unlock-mutex (future-mutex future))
 
         (lock-mutex %futures-mutex)
-        (unregister-future! future)
+        (q-remove! %futures future)
         (unlock-mutex %futures-mutex)
 
         (lock-mutex (future-mutex future))