mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 19:50:24 +02:00
Code Activity

(web server) supports non-utf-8 charsets

Browse source 
* module/web/server.scm (sanitize-response): Support charsets other than
  utf-8. Oddly collecting a string and converting it to utf-8 appears to
  be faster than collecting a utf-8 bytevector directly.
This commit is contained in:
Andy Wingo 2010-12-02 12:28:35 +01:00
parent ee3a800f46
commit af0da6ebe7
1 changed files with 32 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

41
module/web/server.scm
View file

@ -85,6 +85,7 @@
(define-module (web server) (define-module (web server)
#:use-module (srfi srfi-9) #:use-module (srfi srfi-9)
#:use-module (rnrs bytevectors) #:use-module (rnrs bytevectors)
#:use-module (rnrs io ports)
#:use-module (web request) #:use-module (web request)
#:use-module (web response) #:use-module (web response)
#:use-module (system repl error-handling) #:use-module (system repl error-handling)
@ -142,10 +143,25 @@
(warn "Error while accepting client" k args) (warn "Error while accepting client" k args)
(values keep-alive #f #f #f)))) (values keep-alive #f #f #f))))
(define (call-with-encoded-output-string charset proc)
(if (and (string-ci=? charset "utf-8") #f)
;; I don't know why, but this appears to be faster; at least for
;; examples/debug-sxml.scm (650 reqs/s versus 510 reqs/s).
(string->utf8 (call-with-output-string proc))
(call-with-values
(lambda ()
(open-bytevector-output-port))
(lambda (port get-bytevector)
(set-port-encoding! port charset)
(proc port)
(get-bytevector)))))
(define (encode-string str charset) (define (encode-string str charset)
(case charset (if (string-ci=? charset "utf-8")
((utf-8) (string->utf8 str)) (string->utf8 str)
(else (error "unknown charset" charset)))) (call-with-encoded-output-string charset
(lambda (port)
(display str port)))))
;; -> response body ;; -> response body
(define (sanitize-response request response body) (define (sanitize-response request response body)
@ -166,19 +182,26 @@
(let* ((type (response-content-type response (let* ((type (response-content-type response
'("text/plain"))) '("text/plain")))
(declared-charset (assoc-ref (cdr type) "charset")) (declared-charset (assoc-ref (cdr type) "charset"))
(charset (if declared-charset (charset (or declared-charset "utf-8")))
(string->symbol
(string-downcase declared-charset))
'utf-8)))
(sanitize-response (sanitize-response
request request
(if declared-charset (if declared-charset
response response
(extend-response response 'content-type (extend-response response 'content-type
`(,@type ("charset" . ,(symbol->string charset))))) `(,@type ("charset" . ,charset))))
(encode-string body charset)))) (encode-string body charset))))
((procedure? body) ((procedure? body)
(sanitize-response request response (call-with-output-string body))) (let* ((type (response-content-type response
'("text/plain")))
(declared-charset (assoc-ref (cdr type) "charset"))
(charset (or declared-charset "utf-8")))
(sanitize-response
request
(if declared-charset
response
(extend-response response 'content-type
`(,@type ("charset" . ,charset))))
(call-with-encoded-output-string charset body))))
((bytevector? body) ((bytevector? body)
;; check length; assert type; add other required fields? ;; check length; assert type; add other required fields?
(values (let ((rlen (response-content-length response)) (values (let ((rlen (response-content-length response))