mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 11:40:18 +02:00
Code Activity

Updated comments for current threading implementation.

Browse source
This commit is contained in:
Marius Vollmer 2005-03-09 19:14:36 +00:00
parent 0c97d7dd66
commit b2a339f6e5
1 changed files with 4 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

33
libguile/inline.h
View file

@ -121,24 +121,12 @@ scm_cell (scm_t_bits car, scm_t_bits cdr)
/* Initialize the type slot last so that the cell is ignored by the /* Initialize the type slot last so that the cell is ignored by the
GC until it is completely initialized. This is only relevant GC until it is completely initialized. This is only relevant
when the GC can actually run during this code, which it can't for when the GC can actually run during this code, which it can't
cooperating threads, but it might be important when we get true since the GC only runs when all other threads are stopped.
preemptive threads.
*/ */
SCM_GC_SET_CELL_WORD (z, 1, cdr); SCM_GC_SET_CELL_WORD (z, 1, cdr);
SCM_GC_SET_CELL_WORD (z, 0, car); SCM_GC_SET_CELL_WORD (z, 0, car);
#if 0 /*fixme* Hmm... let's consider this later. */
#if !defined(SCM_USE_COOP_THREADS) && !defined(SCM_USE_NULL_THREADS) && !defined(SCM_USE_COPT_THREADS)
/* When we are using preemtive threads, we might need to make
sure that the initial values for the slots are protected until
the cell is completely initialized.
*/
#error review me
scm_remember_upto_here_1 (SCM_PACK (cdr));
#endif
#endif
#if (SCM_DEBUG_CELL_ACCESSES == 1) #if (SCM_DEBUG_CELL_ACCESSES == 1)
if (scm_expensive_debug_cell_accesses_p ) if (scm_expensive_debug_cell_accesses_p )
scm_i_expensive_validation_check (z); scm_i_expensive_validation_check (z);
@ -180,27 +168,14 @@ scm_double_cell (scm_t_bits car, scm_t_bits cbr,
/* Initialize the type slot last so that the cell is ignored by the /* Initialize the type slot last so that the cell is ignored by the
GC until it is completely initialized. This is only relevant GC until it is completely initialized. This is only relevant
when the GC can actually run during this code, which it can't for when the GC can actually run during this code, which it can't
cooperating threads, but it might be important when we get true since the GC only runs when all other threads are stopped.
preemptive threads.
*/ */
SCM_GC_SET_CELL_WORD (z, 1, cbr); SCM_GC_SET_CELL_WORD (z, 1, cbr);
SCM_GC_SET_CELL_WORD (z, 2, ccr); SCM_GC_SET_CELL_WORD (z, 2, ccr);
SCM_GC_SET_CELL_WORD (z, 3, cdr); SCM_GC_SET_CELL_WORD (z, 3, cdr);
SCM_GC_SET_CELL_WORD (z, 0, car); SCM_GC_SET_CELL_WORD (z, 0, car);
#if 0 /*fixme* Hmm... let's consider this later. */
#if !defined(SCM_USE_COOP_THREADS) && !defined(SCM_USE_NULL_THREADS) && !defined(SCM_USE_COPT_THREADS)
/* When we are using non-cooperating threads, we might need to make
sure that the initial values for the slots are protected until
the cell is completely initialized.
*/
#error review me
scm_remember_upto_here_3 (SCM_PACK (cbr), SCM_PACK (ccr), SCM_PACK (cdr));
#endif
#endif
#if (SCM_DEBUG_CELL_ACCESSES == 1) #if (SCM_DEBUG_CELL_ACCESSES == 1)
if (scm_debug_cell_accesses_p) if (scm_debug_cell_accesses_p)
{ {