mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-12 06:41:13 +02:00
Code Activity

(scm_copy_file): Use fstat on the input fd rather than

Browse source 
stat on the filename, to be certain a file rename can't mean we get
info on one filesystem object but open another.  This fstat usage is
similar to Emacs copy-file.
This commit is contained in:
Kevin Ryde 2004-08-05 01:33:08 +00:00
parent 45ba1d0060
commit b412b5a619
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libguile/filesys.c
View file

@ -1348,7 +1348,7 @@ SCM_DEFINE (scm_copy_file, "copy-file", 2, 0, 0,
#define FUNC_NAME s_scm_copy_file #define FUNC_NAME s_scm_copy_file
{ {
int oldfd, newfd; int oldfd, newfd;
int n; int n, rv;
char buf[BUFSIZ]; char buf[BUFSIZ];
struct stat oldstat; struct stat oldstat;
@ -1356,17 +1356,21 @@ SCM_DEFINE (scm_copy_file, "copy-file", 2, 0, 0,
SCM_STRING_COERCE_0TERMINATION_X (oldfile); SCM_STRING_COERCE_0TERMINATION_X (oldfile);
SCM_VALIDATE_STRING (2, newfile); SCM_VALIDATE_STRING (2, newfile);
SCM_STRING_COERCE_0TERMINATION_X (newfile); SCM_STRING_COERCE_0TERMINATION_X (newfile);
if (stat (SCM_STRING_CHARS (oldfile), &oldstat) == -1)
SCM_SYSERROR;
oldfd = open (SCM_STRING_CHARS (oldfile), O_RDONLY); oldfd = open (SCM_STRING_CHARS (oldfile), O_RDONLY);
if (oldfd == -1) if (oldfd == -1)
SCM_SYSERROR; SCM_SYSERROR;
SCM_SYSCALL (rv = fstat (oldfd, &oldstat));
if (rv == -1)
goto err_close_oldfd;
/* use POSIX flags instead of 07777?. */ /* use POSIX flags instead of 07777?. */
newfd = open (SCM_STRING_CHARS (newfile), O_WRONLY | O_CREAT | O_TRUNC, newfd = open (SCM_STRING_CHARS (newfile), O_WRONLY | O_CREAT | O_TRUNC,
oldstat.st_mode & 07777); oldstat.st_mode & 07777);
if (newfd == -1) if (newfd == -1)
{ {
err_close_oldfd:
close (oldfd); close (oldfd);
SCM_SYSERROR; SCM_SYSERROR;
} }