From b572f187afaa2dddc6d0a70b16461a2f506a9511 Mon Sep 17 00:00:00 2001 From: Michael Gran Date: Sat, 22 Mar 2025 05:33:49 -0700 Subject: [PATCH] version.test: incorrect test logic Since string-contains returns an integer on success, this test was reporting unresolved instead of pass on success. * test-suite/tests/version.test ("version reporting works"): fix boolean check logic --- test-suite/tests/version.test | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test-suite/tests/version.test b/test-suite/tests/version.test index 7ea358d4e..43beac3fc 100644 --- a/test-suite/tests/version.test +++ b/test-suite/tests/version.test @@ -1,7 +1,7 @@ ;;;; version.test --- test suite for Guile's version functions -*- scheme -*- ;;;; Greg J. Badros ;;;; -;;;; Copyright (C) 2000,2001,2006,2010,2020 Free Software Foundation, Inc. +;;;; Copyright (C) 2000,2001,2006,2010,2020,2025 Free Software Foundation, Inc. ;;;; ;;;; This library is free software; you can redistribute it and/or ;;;; modify it under the terms of the GNU Lesser General Public @@ -26,7 +26,7 @@ (and (string? (major-version)) (string? (minor-version)) (string? (micro-version)) - (string-contains (version) - (string-append (major-version) "." - (minor-version) "." - (micro-version)))))) + (equal? 0 (string-contains (version) + (string-append (major-version) "." + (minor-version) "." + (micro-version)))))))