mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-12 06:41:13 +02:00
Code Activity

Use GC-robust queues/lists in `threads.c'.

Browse source 
* libguile/threads.c (remqueue, dequeue, on_thread_exit): Initialize the
  "next" link of the item returned/removed.
This commit is contained in:
Ludovic Courtès 2009-09-15 00:39:04 +02:00
parent 706846f667
commit c058db8a5d
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
libguile/threads.c
View file

@ -84,8 +84,14 @@ to_timespec (SCM t, scm_t_timespec *waittime)
} }
} }
/*** Queues */ /*** Queues */
/* Note: We annotate with "GC-robust" assignments whose purpose is to avoid
the risk of false references leading to unbounded retained space as
described in "Bounding Space Usage of Conservative Garbage Collectors",
H.J. Boehm, 2001. */
/* Make an empty queue data structure. /* Make an empty queue data structure.
*/ */
static SCM static SCM
@ -128,6 +134,10 @@ remqueue (SCM q, SCM c)
if (scm_is_eq (c, SCM_CAR (q))) if (scm_is_eq (c, SCM_CAR (q)))
SCM_SETCAR (q, SCM_CDR (c)); SCM_SETCAR (q, SCM_CDR (c));
SCM_SETCDR (prev, SCM_CDR (c)); SCM_SETCDR (prev, SCM_CDR (c));
/* GC-robust */
SCM_SETCDR (c, SCM_EOL);
SCM_CRITICAL_SECTION_END; SCM_CRITICAL_SECTION_END;
return 1; return 1;
} }
@ -157,6 +167,10 @@ dequeue (SCM q)
if (scm_is_null (SCM_CDR (q))) if (scm_is_null (SCM_CDR (q)))
SCM_SETCAR (q, SCM_EOL); SCM_SETCAR (q, SCM_EOL);
SCM_CRITICAL_SECTION_END; SCM_CRITICAL_SECTION_END;
/* GC-robust */
SCM_SETCDR (c, SCM_EOL);
return SCM_CAR (c); return SCM_CAR (c);
} }
} }
@ -477,6 +491,10 @@ on_thread_exit (void *v)
if (*tp == t) if (*tp == t)
{ {
*tp = t->next_thread; *tp = t->next_thread;
/* GC-robust */
t->next_thread = NULL;
break; break;
} }
thread_count--; thread_count--;