mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-08 21:20:19 +02:00
Code Activity

Fix parallel tracer to force workers to be stopped during pauses

Browse source
This commit is contained in:
Andy Wingo 2024-07-11 15:52:57 +02:00
parent 5084730471
commit c226570a81
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/parallel-tracer.h
View file

@ -125,6 +125,7 @@ gc_tracer_init(struct gc_tracer *tracer, struct gc_heap *heap,
for (size_t i = 1; i < desired_worker_count; i++) { for (size_t i = 1; i < desired_worker_count; i++) {
if (!trace_worker_init(&tracer->workers[i], heap, tracer, i)) if (!trace_worker_init(&tracer->workers[i], heap, tracer, i))
break; break;
pthread_mutex_lock(&tracer->workers[i].lock);
if (trace_worker_spawn(&tracer->workers[i])) if (trace_worker_spawn(&tracer->workers[i]))
tracer->worker_count++; tracer->worker_count++;
else else
@ -256,9 +257,11 @@ trace_worker_should_continue(struct gc_trace_worker *worker) {
} }
int done = (locked == tracer->worker_count) && int done = (locked == tracer->worker_count) &&
!trace_worker_can_steal_from_any(worker, tracer); !trace_worker_can_steal_from_any(worker, tracer);
if (done)
return 0;
while (locked > 1) while (locked > 1)
pthread_mutex_unlock(&tracer->workers[--locked].lock); pthread_mutex_unlock(&tracer->workers[--locked].lock);
return !done; return 1;
} }
// spin // spin
LOG("checking for termination: spinning #%zu\n", spin_count); LOG("checking for termination: spinning #%zu\n", spin_count);
@ -350,6 +353,9 @@ static inline void
gc_tracer_trace(struct gc_tracer *tracer) { gc_tracer_trace(struct gc_tracer *tracer) {
DEBUG("starting trace; %zu workers\n", tracer->worker_count); DEBUG("starting trace; %zu workers\n", tracer->worker_count);
for (int i = 1; i < tracer->worker_count; i++)
pthread_mutex_unlock(&tracer->workers[i].lock);
ssize_t parallel_threshold = ssize_t parallel_threshold =
LOCAL_WORKLIST_SIZE - LOCAL_WORKLIST_SHARE_AMOUNT; LOCAL_WORKLIST_SIZE - LOCAL_WORKLIST_SHARE_AMOUNT;
if (root_worklist_size(&tracer->roots) > 1 || if (root_worklist_size(&tracer->roots) > 1 ||