mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 11:50:28 +02:00
Code Activity

Add error handling for spawn's posix_spawn_file_actions_adddup2.

Browse source 
* libguile/posix.c (do_spawn): Add error handling if
posix_spawn_file_actions_adddup2 fails.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
This commit is contained in:
Josselin Poiret 2023-05-05 15:39:22 +02:00 • committed by Ludovic Courtès
parent 6efc0b8159
commit ccd7400fdb
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
1 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
libguile/posix.c
View file

@ -1390,12 +1390,19 @@ do_spawn (char *exec_file, char **exec_argv, char **exec_env,
/* Move the fds out of the way, so that duplicate fds or fds equal /* Move the fds out of the way, so that duplicate fds or fds equal
to 0, 1, 2 don't trample each other */ to 0, 1, 2 don't trample each other */
posix_spawn_file_actions_adddup2 (&actions, in, fd_slot[0]); int dup2_action_from[] = {in, out, err,
posix_spawn_file_actions_adddup2 (&actions, out, fd_slot[1]); fd_slot[0], fd_slot[1], fd_slot[2]};
posix_spawn_file_actions_adddup2 (&actions, err, fd_slot[2]); int dup2_action_to [] = {fd_slot[0], fd_slot[1], fd_slot[2],
posix_spawn_file_actions_adddup2 (&actions, fd_slot[0], 0); 0, 1, 2};
posix_spawn_file_actions_adddup2 (&actions, fd_slot[1], 1);
posix_spawn_file_actions_adddup2 (&actions, fd_slot[2], 2); errno = 0;
for (int i = 0; i < sizeof (dup2_action_from) / sizeof (int); i++)
{
errno = posix_spawn_file_actions_adddup2 (&actions, dup2_action_from[i],
dup2_action_to[i]);
if (errno != 0)
return -1;
}
#ifdef HAVE_ADDCLOSEFROM #ifdef HAVE_ADDCLOSEFROM
/* This function appears in glibc 2.34. It's both free from race /* This function appears in glibc 2.34. It's both free from race