mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 03:40:34 +02:00
Code Activity

bitvector-bit-set? / bitvector-bit-clear? replace bitvector-ref

Browse source 
This is an opportunity to make a new interface that can be more
efficient in 3.0 (because no generic array support), easier to read (no
need for 'not'), and more consistent with other bitvector interfaces.

* NEWS: Add entry.
* doc/ref/api-data.texi (Bit Vectors): Update.
* libguile/array-handle.h (bitvector_ref, scm_array_get_handle): Adapt
  to bitvector changes.
* libguile/bitvectors.h:
* libguile/bitvectors.c (scm_c_bitvector_bit_is_set)
  (scm_c_bitvector_bit_is_clear): New functions.
* libguile/deprecated.h:
* libguile/deprecated.c (scm_bitvector_ref): Deprecate.
* module/ice-9/sandbox.scm (bitvector-bindings): Replace
  bitvector-ref with bitvector-bit-set? / bitvector-bit-clear?.
* module/system/vm/disassembler.scm (instruction-has-fallthrough): Use
  bitvector-bit-clear?.
* test-suite/tests/bitvectors.test: Update.
This commit is contained in:
Andy Wingo 2020-04-14 22:08:45 +02:00
parent ff9979b6bc
commit d804177be4
10 changed files with 106 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libguile/array-handle.c
View file

@ -27,6 +27,7 @@
#include <string.h>
#include "arrays.h"
#include "boolean.h"
#include "bitvectors.h"
#include "bytevectors.h"
#include "list.h"
@ -167,6 +168,12 @@ initialize_vector_handle (scm_t_array_handle *h, size_t len,
h->vset = vset;
}
static SCM
bitvector_ref (SCM bv, size_t idx)
{
return scm_from_bool (scm_c_bitvector_bit_is_set (bv, idx));
}
void
scm_array_get_handle (SCM array, scm_t_array_handle *h)
{
@ -194,7 +201,8 @@ scm_array_get_handle (SCM array, scm_t_array_handle *h)
case scm_tc7_bitvector:
initialize_vector_handle (h, scm_c_bitvector_length (array),
SCM_ARRAY_ELEMENT_TYPE_BIT,
scm_c_bitvector_ref, scm_c_bitvector_set_x,
bitvector_ref,
scm_c_bitvector_set_x,
scm_i_bitvector_bits (array),
scm_i_is_mutable_bitvector (array));
break;