mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-20 11:40:18 +02:00
Code Activity

Make the "Dia Primitives" section of the manual more clear.

Browse source 
* doc/ref/libguile-program.texi (Dia Primitives): Use
  scm_assert_smob_type, and update the text.
This commit is contained in:
Andy Wingo 2011-12-22 09:32:09 -05:00
parent 61fe8eafc2
commit e0a8221dcf
1 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
doc/ref/libguile-program.texi
View file

@ -279,13 +279,12 @@ As an example, here is a possible implementation of the @code{square?}
primitive: primitive:
@lisp @lisp
#define FUNC_NAME "square?"
static SCM square_p (SCM shape) static SCM square_p (SCM shape)
@{ @{
struct dia_guile_shape * guile_shape; struct dia_guile_shape * guile_shape;
/* Check that arg is really a shape SMOB. */ /* Check that arg is really a shape SMOB. */
SCM_VALIDATE_SHAPE (SCM_ARG1, shape); scm_assert_smob_type (shape_tag, shape);
/* Access Scheme-specific shape structure. */ /* Access Scheme-specific shape structure. */
guile_shape = SCM_SMOB_DATA (shape); guile_shape = SCM_SMOB_DATA (shape);
@ -295,7 +294,6 @@ static SCM square_p (SCM shape)
return scm_from_bool (guile_shape->c_shape && return scm_from_bool (guile_shape->c_shape &&
(guile_shape->c_shape->type == DIA_SQUARE)); (guile_shape->c_shape->type == DIA_SQUARE));
@} @}
#undef FUNC_NAME
@end lisp @end lisp
Notice how easy it is to chain through from the @code{SCM shape} Notice how easy it is to chain through from the @code{SCM shape}
@ -303,10 +301,11 @@ parameter that @code{square_p} receives --- which is a SMOB --- to the
Scheme-specific structure inside the SMOB, and thence to the underlying Scheme-specific structure inside the SMOB, and thence to the underlying
C structure for the shape. C structure for the shape.
In this code, @code{SCM_SMOB_DATA} and @code{scm_from_bool} are from In this code, @code{scm_assert_smob_type}, @code{SCM_SMOB_DATA}, and
the standard Guile API. @code{SCM_VALIDATE_SHAPE} is a macro that you @code{scm_from_bool} are from the standard Guile API. We assume that
should define as part of your SMOB definition: it checks that the @code{shape_tag} was given to us when we made the shape SMOB type, using
passed parameter is of the expected type. This is needed to guard @code{scm_make_smob_type}. The call to @code{scm_assert_smob_type}
ensures that @var{shape} is indeed a shape. This is needed to guard
against Scheme code using the @code{square?} procedure incorrectly, as against Scheme code using the @code{square?} procedure incorrectly, as
in @code{(square? "hello")}; Scheme's latent typing means that usage in @code{(square? "hello")}; Scheme's latent typing means that usage
errors like this must be caught at run time. errors like this must be caught at run time.