mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-05-19 11:10:25 +02:00
Code Activity

Add missing write barriers to finalizers.c

Browse source
This commit is contained in:
Andy Wingo 2025-01-13 10:23:47 +01:00
parent b37a7f3862
commit e41000094d
1 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

22
benchmarks/finalizers.c
View file

@ -93,6 +93,24 @@ static void cause_gc(struct gc_mutator *mut) {
gc_collect(mut, GC_COLLECTION_MAJOR); gc_collect(mut, GC_COLLECTION_MAJOR);
} }
static inline void set_car(struct gc_mutator *mut, Pair *obj, void *val) {
void **field = &obj->car;
if (val)
gc_write_barrier(mut, gc_ref_from_heap_object(obj), sizeof(Pair),
gc_edge(field),
gc_ref_from_heap_object(val));
*field = val;
}
static inline void set_cdr(struct gc_mutator *mut, Pair *obj, void *val) {
void **field = &obj->cdr;
if (val)
gc_write_barrier(mut, gc_ref_from_heap_object(obj), sizeof(Pair),
gc_edge(field),
gc_ref_from_heap_object(val));
field = val;
}
static Pair* make_finalizer_chain(struct thread *t, size_t length) { static Pair* make_finalizer_chain(struct thread *t, size_t length) {
PairHandle head = { NULL }; PairHandle head = { NULL };
PairHandle tail = { NULL }; PairHandle tail = { NULL };
@ -102,8 +120,8 @@ static Pair* make_finalizer_chain(struct thread *t, size_t length) {
for (size_t i = 0; i < length; i++) { for (size_t i = 0; i < length; i++) {
HANDLE_SET(tail, HANDLE_REF(head)); HANDLE_SET(tail, HANDLE_REF(head));
HANDLE_SET(head, allocate_pair(t->mut)); HANDLE_SET(head, allocate_pair(t->mut));
HANDLE_REF(head)->car = allocate_small_object(t->mut); set_car(t->mut, HANDLE_REF(head), allocate_small_object(t->mut));
HANDLE_REF(head)->cdr = HANDLE_REF(tail); set_cdr(t->mut, HANDLE_REF(head), HANDLE_REF(tail));
struct gc_finalizer *finalizer = allocate_finalizer(t->mut); struct gc_finalizer *finalizer = allocate_finalizer(t->mut);
gc_finalizer_attach(t->mut, finalizer, 0, gc_finalizer_attach(t->mut, finalizer, 0,
gc_ref_from_heap_object(HANDLE_REF(head)), gc_ref_from_heap_object(HANDLE_REF(head)),