mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-17 17:20:29 +02:00
Code Activity

Zero-offset branches are backward branches; fix "br" backward branches

Browse source 
* libguile/vm-engine.c (BR_UNARY, BR_BINARY, BR_ARITHMETIC): A jump with
  a zero offset is also a backward branch, in the sense that it's not a
  forward branch.
  ("br"): We forgot to VM_HANDLE_INTERRUPTS here on backwards branches.
  Oops!
This commit is contained in:
Andy Wingo 2014-02-22 15:39:29 +01:00
parent 90c8094aec
commit fcd3c8ccd3
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libguile/vm-engine.c
View file

@ -305,7 +305,7 @@
{ \ { \
scm_t_int32 offset = ip[1]; \ scm_t_int32 offset = ip[1]; \
offset >>= 8; /* Sign-extending shift. */ \ offset >>= 8; /* Sign-extending shift. */ \
if (offset < 0) \ if (offset <= 0) \
VM_HANDLE_INTERRUPTS; \ VM_HANDLE_INTERRUPTS; \
NEXT (offset); \ NEXT (offset); \
} \ } \
@ -321,7 +321,7 @@
{ \ { \
scm_t_int32 offset = ip[1]; \ scm_t_int32 offset = ip[1]; \
offset >>= 8; /* Sign-extending shift. */ \ offset >>= 8; /* Sign-extending shift. */ \
if (offset < 0) \ if (offset <= 0) \
VM_HANDLE_INTERRUPTS; \ VM_HANDLE_INTERRUPTS; \
NEXT (offset); \ NEXT (offset); \
} \ } \
@ -342,7 +342,7 @@
{ \ { \
scm_t_int32 offset = ip[1]; \ scm_t_int32 offset = ip[1]; \
offset >>= 8; /* Sign-extending shift. */ \ offset >>= 8; /* Sign-extending shift. */ \
if (offset < 0) \ if (offset <= 0) \
VM_HANDLE_INTERRUPTS; \ VM_HANDLE_INTERRUPTS; \
NEXT (offset); \ NEXT (offset); \
} \ } \
@ -358,7 +358,7 @@
{ \ { \
scm_t_int32 offset = ip[1]; \ scm_t_int32 offset = ip[1]; \
offset >>= 8; /* Sign-extending shift. */ \ offset >>= 8; /* Sign-extending shift. */ \
if (offset < 0) \ if (offset <= 0) \
VM_HANDLE_INTERRUPTS; \ VM_HANDLE_INTERRUPTS; \
NEXT (offset); \ NEXT (offset); \
} \ } \
@ -1347,6 +1347,8 @@ VM_NAME (scm_i_thread *thread, struct scm_vm *vp,
{ {
scm_t_int32 offset = op; scm_t_int32 offset = op;
offset >>= 8; /* Sign-extending shift. */ offset >>= 8; /* Sign-extending shift. */
if (offset <= 0)
VM_HANDLE_INTERRUPTS;
NEXT (offset); NEXT (offset);
} }