mirror of
https://git.savannah.gnu.org/git/guile.git
synced 2025-04-29 19:30:36 +02:00
Partial fix for <https://bugs.gnu.org/33044>. Reported by Tom de Vries <tdevries@suse.de>. Fix several instances of the mistake of using 'scm_from_locale_*' for C strings that originally came from a C string literal. Change several uses of 'scm_from_latin1_*' as well, to promote the practice of writing code that works for arbitrary C string literals. Also add missing years to the copyright notices of changed files, based on the git history. * libguile/debug-malloc.c, libguile/deprecation.c, libguile/error.c, libguile/eval.c, libguile/expand.c, libguile/extensions.c, libguile/filesys.c, libguile/init.c, libguile/load.c, libguile/modules.c, libguile/pairs.c, libguile/posix.c, libguile/print.c, libguile/random.c, libguile/read.c, libguile/regex-posix.c, libguile/snarf.h, libguile/srfi-13.c, libguile/stacks.c, libguile/stime.c, libguile/strports.c, libguile/values.c: Use 'scm_from_utf8_*' where appropriate.
180 lines
4.6 KiB
C
180 lines
4.6 KiB
C
/* Copyright 2001,2005-2006,2009-2012,2016,2018-2019
|
||
Free Software Foundation, Inc.
|
||
|
||
This file is part of Guile.
|
||
|
||
Guile is free software: you can redistribute it and/or modify it
|
||
under the terms of the GNU Lesser General Public License as published
|
||
by the Free Software Foundation, either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
Guile is distributed in the hope that it will be useful, but WITHOUT
|
||
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||
FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public
|
||
License for more details.
|
||
|
||
You should have received a copy of the GNU Lesser General Public
|
||
License along with Guile. If not, see
|
||
<https://www.gnu.org/licenses/>. */
|
||
|
||
|
||
|
||
#ifdef HAVE_CONFIG_H
|
||
# include <config.h>
|
||
#endif
|
||
|
||
#include <stdio.h>
|
||
#include <string.h>
|
||
#include <stdarg.h>
|
||
|
||
#include "gsubr.h"
|
||
#include "list.h"
|
||
#include "pairs.h"
|
||
#include "ports.h"
|
||
#include "private-options.h"
|
||
#include "strings.h"
|
||
#include "threads.h"
|
||
|
||
#include "deprecation.h"
|
||
|
||
|
||
|
||
struct issued_warning {
|
||
struct issued_warning *prev;
|
||
const char *message;
|
||
};
|
||
|
||
static scm_i_pthread_mutex_t warn_lock = SCM_I_PTHREAD_MUTEX_INITIALIZER;
|
||
static struct issued_warning *issued_warnings;
|
||
static int print_summary = 0;
|
||
|
||
void
|
||
scm_c_issue_deprecation_warning (const char *msg)
|
||
{
|
||
if (!SCM_WARN_DEPRECATED)
|
||
print_summary = 1;
|
||
else
|
||
{
|
||
struct issued_warning *iw;
|
||
|
||
scm_i_pthread_mutex_lock (&warn_lock);
|
||
for (iw = issued_warnings; iw; iw = iw->prev)
|
||
if (!strcmp (iw->message, msg))
|
||
{
|
||
msg = NULL;
|
||
break;
|
||
}
|
||
if (msg)
|
||
{
|
||
msg = strdup (msg);
|
||
iw = malloc (sizeof (struct issued_warning));
|
||
if (msg == NULL || iw == NULL)
|
||
/* Nothing sensible to do if you can't allocate this small
|
||
amount of memory. */
|
||
abort ();
|
||
iw->message = msg;
|
||
iw->prev = issued_warnings;
|
||
issued_warnings = iw;
|
||
}
|
||
scm_i_pthread_mutex_unlock (&warn_lock);
|
||
|
||
/* All this dance is to avoid printing to a port inside a mutex,
|
||
which could recurse and deadlock. */
|
||
if (msg)
|
||
{
|
||
scm_puts (msg, scm_current_warning_port ());
|
||
scm_newline (scm_current_warning_port ());
|
||
}
|
||
}
|
||
}
|
||
|
||
void
|
||
scm_c_issue_deprecation_warning_fmt (const char *msg, ...)
|
||
{
|
||
va_list ap;
|
||
char buf[512];
|
||
|
||
va_start (ap, msg);
|
||
vsnprintf (buf, 511, msg, ap);
|
||
va_end (ap);
|
||
buf[511] = '\0';
|
||
scm_c_issue_deprecation_warning (buf);
|
||
}
|
||
|
||
SCM_DEFINE(scm_issue_deprecation_warning,
|
||
"issue-deprecation-warning", 0, 0, 1,
|
||
(SCM msgs),
|
||
"Output @var{msgs} to @code{(current-error-port)} when this "
|
||
"is the first call to @code{issue-deprecation-warning} with "
|
||
"this specific @var{msgs}. Do nothing otherwise. "
|
||
"The argument @var{msgs} should be a list of strings; "
|
||
"they are printed in turn, each one followed by a newline.")
|
||
#define FUNC_NAME s_scm_issue_deprecation_warning
|
||
{
|
||
if (!SCM_WARN_DEPRECATED)
|
||
print_summary = 1;
|
||
else
|
||
{
|
||
SCM nl = scm_from_utf8_string ("\n");
|
||
SCM msgs_nl = SCM_EOL;
|
||
char *c_msgs;
|
||
while (scm_is_pair (msgs))
|
||
{
|
||
if (!scm_is_null (msgs_nl))
|
||
msgs_nl = scm_cons (nl, msgs_nl);
|
||
msgs_nl = scm_cons (SCM_CAR (msgs), msgs_nl);
|
||
msgs = SCM_CDR (msgs);
|
||
}
|
||
msgs_nl = scm_string_append (scm_reverse_x (msgs_nl, SCM_EOL));
|
||
c_msgs = scm_to_locale_string (msgs_nl);
|
||
scm_c_issue_deprecation_warning (c_msgs);
|
||
free (c_msgs);
|
||
}
|
||
return SCM_UNSPECIFIED;
|
||
}
|
||
#undef FUNC_NAME
|
||
|
||
static void
|
||
print_deprecation_summary (void)
|
||
{
|
||
if (print_summary)
|
||
{
|
||
fputs ("\n"
|
||
"Some deprecated features have been used. Set the environment\n"
|
||
"variable GUILE_WARN_DEPRECATED to \"detailed\" and rerun the\n"
|
||
"program to get more information. Set it to \"no\" to suppress\n"
|
||
"this message.\n", stderr);
|
||
}
|
||
}
|
||
|
||
SCM_DEFINE(scm_include_deprecated_features,
|
||
"include-deprecated-features", 0, 0, 0,
|
||
(),
|
||
"Return @code{#t} iff deprecated features should be included "
|
||
"in public interfaces.")
|
||
#define FUNC_NAME s_scm_include_deprecated_features
|
||
{
|
||
return scm_from_bool (SCM_ENABLE_DEPRECATED == 1);
|
||
}
|
||
#undef FUNC_NAME
|
||
|
||
|
||
|
||
|
||
void
|
||
scm_init_deprecation ()
|
||
{
|
||
const char *level = getenv ("GUILE_WARN_DEPRECATED");
|
||
if (level == NULL)
|
||
level = SCM_WARN_DEPRECATED_DEFAULT;
|
||
if (!strcmp (level, "detailed"))
|
||
SCM_WARN_DEPRECATED = 1;
|
||
else if (!strcmp (level, "no"))
|
||
SCM_WARN_DEPRECATED = 0;
|
||
else
|
||
{
|
||
SCM_WARN_DEPRECATED = 0;
|
||
atexit (print_deprecation_summary);
|
||
}
|
||
#include "deprecation.x"
|
||
}
|