1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-29 19:30:36 +02:00
guile/test-suite/tests/error-handling.test
Andy Wingo 6efc0b8159 call-with-values builtin doesn't leave garbage on the stack
Fixes https://debbugs.gnu.org/63279.  The issue was that if the producer
thunk caused a backtrace, pretty-printing the call-with-values frame
would segfault because there was an unininitialized slot on the stack.
For functions produced by the compiler this wouldn't be a problem
because there are stack maps, but primitives require that all slots on a
pending stack frame be packed (no uninitialized values) and tagged (all
SCM values, no unboxed values).

* test-suite/tests/error-handling.test: New test.
* test-suite/Makefile.am: Add new file.
* libguile/vm.c (define_vm_builtins): Fix call-with-values to have a
more compact stack.
2023-05-07 09:50:14 +02:00

37 lines
1.6 KiB
Scheme

;;; Test for call-with-error-handling. -*- scheme -*-
;;; Copyright (C) 2023
;;; Free Software Foundation, Inc.
;;;
;;; This library is free software: you can redistribute it and/or modify
;;; it under the terms of the GNU Lesser General Public License as
;;; published by the Free Software Foundation, either version 3 of the
;;; License, or (at your option) any later version.
;;;
;;; This library is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
;;; Lesser General Public License for more details.
;;;
;;; You should have received a copy of the GNU Lesser General Public
;;; License along with this program. If not, see
;;; <http://www.gnu.org/licenses/>.
(define-module (test-suite test-error-handling)
#:use-module (test-suite lib)
#:use-module (system base compile)
#:use-module (system repl error-handling))
(with-test-prefix "call-with-values"
(pass-if "backtrace with builtin"
(let* ((thunk (compile '(lambda ()
(symbol?
(call-with-values (lambda () (error 'oh-no))
list)))))
(str (with-output-to-string
(lambda ()
(call-with-error-handling thunk #:on-error 'backtrace))))
(lines (string-split str #\newline)))
;; For https://debbugs.gnu.org/63279, we just want to ensure that
;; the backtrace completes. The check is just that the backtrace
;; has at least a couple frames.
(>= (length lines) 4))))