1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-04-30 03:40:34 +02:00
guile/module
Michael Käppler 80d4055e42
Fix error messages containing format strings
The builtin primitive procedure `error` takes an optional message and
a list of arguments to include into the error message.
These args are formatted with `~S` and appended to the error message, so
that an example call of

`(error "Wrong argument: " 42)`

results in the output

"Wrong argument: 42"

If format strings occur in the message itself, however, they are
escaped. Thus a call like

`(error "Wrong argument: ~a" 42)`

is rendered as

"Wrong argument: ~a 42"

Some callers did not take this behavior into account, leading to
confusing error messages.
Changing the behavior of `error` to be
both backwards-compatible and accept also format strings inside messages
is not straightforward, because it would have to handle escaped `~`
characters as well. Therefore, fix `error` call sites using format
strings to use `format` before calling out to `error`.

The following files are affected:

* module/ice-9/format.scm (format)
* module/ice-9/r6rs-libraries.scm (resolve-r6rs-interface)
* module/oop/goops.scm (make)
* module/srfi/srfi-37.scm (Comment at the beginning of file)
* module/system/base/compile.scm (call-once)
* module/system/repl/command.scm (break, tracepoint)
* module/system/repl/common.scm (repl-default-options)
* module/system/vm/traps.scm (arg-check, trap-at-source-location)

There are a couple of further call sites that were left unchanged,
either because they are using their own `error` procedure:

* module/ice-9/read.scm
* module/ice-9/command-line.scm

or are not referenced from other modules:

* module/system/base/lalr.upstream.scm:
* module/sxml/upstream/assert.scm:
* module/sxml/sxml-match.ss:

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
2024-05-06 11:51:53 +02:00
..
ice-9 Fix error messages containing format strings 2024-05-06 11:51:53 +02:00
language Fix typos throughout codebase. 2024-05-06 11:51:53 +02:00
oop Fix error messages containing format strings 2024-05-06 11:51:53 +02:00
rnrs Implement R6RS custom textual ports 2023-06-08 10:21:02 +02:00
scheme Update set of decimal zeroes for Unicode 15.1.0 2023-11-02 11:31:32 +01:00
scripts Bump user-visible copyright years to 2024. 2024-01-24 10:49:27 +01:00
srfi Fix error messages containing format strings 2024-05-06 11:51:53 +02:00
sxml Remove unnecessary module imports. 2023-02-24 16:49:00 +01:00
system Fix error messages containing format strings 2024-05-06 11:51:53 +02:00
texinfo Fix typos throughout codebase. 2024-05-06 11:51:53 +02:00
web Use custom binary output ports for make-chunked-output-port 2023-06-08 09:03:10 +02:00
Makefile.am Rework bootstrap to be reproducible 2022-02-01 14:50:40 +01:00
rnrs.scm Define top-level bindings for aux syntax: else, =>, _, ... 2019-09-12 21:50:51 +02:00
statprof.scm Fix typos throughout codebase. 2024-05-06 11:51:53 +02:00
texinfo.scm texinfo: Add basic support for @w{...}. 2020-06-18 00:30:30 +02:00