mirror/guile
mirror/guile
1
Fork 0
mirror of https://git.savannah.gnu.org/git/guile.git synced 2025-06-17 01:00:20 +02:00
Code Activity

* hashtab.c: Undid thread safety. (We decided that it's better to

Browse source 
let the user explicitly protect the tables (or not) according what
is suitable for the application.)
This commit is contained in:
Mikael Djurfeldt 2003-02-13 10:42:59 +00:00
parent 87ca11ff19
commit 0a4c135550
3 changed files with 61 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libguile/ChangeLog
View file

@ -1,3 +1,9 @@
2003-02-13 Mikael Djurfeldt <djurfeldt@nada.kth.se>
* hashtab.c: Undid thread safety. (We decided that it's better to
let the user explicitly protect the tables (or not) according what
is suitable for the application.)
2003-02-12 Mikael Djurfeldt <djurfeldt@nada.kth.se> 2003-02-12 Mikael Djurfeldt <djurfeldt@nada.kth.se>
* hashtab.c (scm_hash_fn_remove_x, scm_internal_hash_fold): Made * hashtab.c (scm_hash_fn_remove_x, scm_internal_hash_fold): Made

148
libguile/hashtab.c
View file

@ -59,9 +59,19 @@
containing such vectors. Currently, the vector version represents containing such vectors. Currently, the vector version represents
constant size tables while those wrapped in a smob represents constant size tables while those wrapped in a smob represents
resizing tables. resizing tables.
*/
/*fixme* Decrement and rehash when removing elemnts from a table. Growing or shrinking, with following rehashing, is triggered when
the load factor
L = N / S (N: number of items in table, S: bucket vector length)
passes an upper limit of 0.9 or a lower limit of 0.25.
The implementation stores the upper and lower number of items which
trigger a resize in the hashtable object.
Possible hash table sizes (primes) are stored in the array
hashtable_size.
*/ */
/*fixme* Update n_items correctly for weak tables. This can be done /*fixme* Update n_items correctly for weak tables. This can be done
@ -82,23 +92,21 @@
scm_t_bits scm_tc16_hashtable; scm_t_bits scm_tc16_hashtable;
typedef struct scm_t_hashtable { typedef struct scm_t_hashtable {
unsigned long n_items; unsigned long n_items; /* number of items in table */
unsigned long lower; unsigned long lower; /* when to shrink */
unsigned long upper; unsigned long upper; /* when to grow */
int size_index; int size_index; /* index into hashtable_size */
scm_t_rec_mutex mutex;
} scm_t_hashtable; } scm_t_hashtable;
#define HASHTABLE_SIZE_N 23 #define HASHTABLE_SIZE_N 25
unsigned long hashtable_size[] = { static unsigned long hashtable_size[] = {
37, 73, 139, 293, 587, 1181, 2357, 4733, 9467, 18919, 37879, 75773, 31, 61, 113, 223, 443, 883, 1759, 3517, 7027, 14051, 28099, 56197, 112363,
151549, 303097, 606181, 1212401, 2424827, 4849651, 9699323, 19398647, 224717, 449419, 898823, 1797641, 3595271, 7190537, 14381041, 28762081,
38797303, 77594599, 155189239 57524111, 115048217, 230096423, 460192829 /* larger values can't be
represented as INUMs */
}; };
static scm_t_rec_mutex common_hashtable_mutex;
/* Turn an empty vector hash table into an opaque resizable one. */ /* Turn an empty vector hash table into an opaque resizable one. */
static char *s_hashtable = "hashtable"; static char *s_hashtable = "hashtable";
@ -119,7 +127,6 @@ scm_vector_to_hash_table (SCM vector) {
else else
t->lower = hashtable_size[i] / 4; t->lower = hashtable_size[i] / 4;
t->upper = 9 * hashtable_size[i] / 10; t->upper = 9 * hashtable_size[i] / 10;
scm_i_plugin_rec_mutex_init (&t->mutex, &scm_i_plugin_rec_mutex);
SCM_NEWSMOB2 (table, scm_tc16_hashtable, vector, t); SCM_NEWSMOB2 (table, scm_tc16_hashtable, vector, t);
return table; return table;
} }
@ -154,7 +161,7 @@ scm_c_make_hash_table (unsigned long k)
SCM SCM
scm_c_make_resizing_hash_table () scm_c_make_resizing_hash_table ()
{ {
return scm_vector_to_hash_table (scm_c_make_vector (37, SCM_EOL)); return scm_vector_to_hash_table (scm_c_make_vector (31, SCM_EOL));
} }
SCM_DEFINE (scm_make_hash_table, "make-hash-table", 0, 1, 0, SCM_DEFINE (scm_make_hash_table, "make-hash-table", 0, 1, 0,
@ -181,10 +188,20 @@ rehash (SCM table, unsigned long (*hash_fn)(), void *closure)
int i; int i;
unsigned long old_size; unsigned long old_size;
unsigned long new_size; unsigned long new_size;
if (SCM_HASHTABLE_N_ITEMS (table) < SCM_HASHTABLE_LOWER (table)) if (SCM_HASHTABLE_N_ITEMS (table) < SCM_HASHTABLE_LOWER (table))
/* rehashing is never triggered when i == 0 */
i = --SCM_HASHTABLE (table)->size_index; i = --SCM_HASHTABLE (table)->size_index;
else else
i = ++SCM_HASHTABLE (table)->size_index; {
i = SCM_HASHTABLE (table)->size_index + 1;
if (i < HASHTABLE_SIZE_N)
SCM_HASHTABLE (table)->size_index = i;
else
/* don't rehash */
return;
}
new_size = hashtable_size[i]; new_size = hashtable_size[i];
if (i == 0) if (i == 0)
SCM_HASHTABLE (table)->lower = 0; SCM_HASHTABLE (table)->lower = 0;
@ -224,11 +241,7 @@ rehash (SCM table, unsigned long (*hash_fn)(), void *closure)
continue; continue;
h = hash_fn (SCM_CAR (handle), new_size, closure); h = hash_fn (SCM_CAR (handle), new_size, closure);
if (h >= new_size) if (h >= new_size)
{ scm_out_of_range ("hash_fn_create_handle_x", scm_ulong2num (h));
scm_rec_mutex_unlock (&SCM_HASHTABLE (table)->mutex);
scm_out_of_range ("hash_fn_create_handle_x",
scm_ulong2num (h));
}
SCM_VECTOR_SET (new_buckets, h, SCM_VECTOR_SET (new_buckets, h,
scm_cons (handle, SCM_VELTS (new_buckets)[h])); scm_cons (handle, SCM_VELTS (new_buckets)[h]));
ls = SCM_CDR (ls); ls = SCM_CDR (ls);
@ -243,29 +256,17 @@ scm_hash_fn_get_handle (SCM table, SCM obj, unsigned long (*hash_fn)(), SCM (*as
{ {
unsigned long k; unsigned long k;
SCM h; SCM h;
scm_t_rec_mutex *m;
if (SCM_HASHTABLE_P (table)) if (SCM_HASHTABLE_P (table))
{ table = SCM_HASHTABLE_VECTOR (table);
m = &SCM_HASHTABLE (table)->mutex;
table = SCM_HASHTABLE_VECTOR (table);
}
else else
{ SCM_VALIDATE_VECTOR (1, table);
SCM_VALIDATE_VECTOR (1, table);
m = &common_hashtable_mutex;
}
if (SCM_VECTOR_LENGTH (table) == 0) if (SCM_VECTOR_LENGTH (table) == 0)
return SCM_BOOL_F; return SCM_BOOL_F;
scm_rec_mutex_lock (m);
k = hash_fn (obj, SCM_VECTOR_LENGTH (table), closure); k = hash_fn (obj, SCM_VECTOR_LENGTH (table), closure);
if (k >= SCM_VECTOR_LENGTH (table)) if (k >= SCM_VECTOR_LENGTH (table))
{ scm_out_of_range ("hash_fn_get_handle", scm_ulong2num (k));
scm_rec_mutex_unlock (m);
scm_out_of_range ("hash_fn_get_handle", scm_ulong2num (k));
}
h = assoc_fn (obj, SCM_VELTS (table)[k], closure); h = assoc_fn (obj, SCM_VELTS (table)[k], closure);
scm_rec_mutex_unlock (m);
return h; return h;
} }
#undef FUNC_NAME #undef FUNC_NAME
@ -278,40 +279,29 @@ scm_hash_fn_create_handle_x (SCM table, SCM obj, SCM init, unsigned long (*hash_
{ {
unsigned long k; unsigned long k;
SCM buckets, it; SCM buckets, it;
scm_t_rec_mutex *m;
if (SCM_HASHTABLE_P (table)) if (SCM_HASHTABLE_P (table))
{ buckets = SCM_HASHTABLE_VECTOR (table);
buckets = SCM_HASHTABLE_VECTOR (table);
m = &SCM_HASHTABLE (table)->mutex;
}
else else
{ {
SCM_ASSERT (SCM_VECTORP (table), SCM_ASSERT (SCM_VECTORP (table),
table, SCM_ARG1, "hash_fn_create_handle_x"); table, SCM_ARG1, "hash_fn_create_handle_x");
buckets = table; buckets = table;
m = &common_hashtable_mutex;
} }
if (SCM_VECTOR_LENGTH (buckets) == 0) if (SCM_VECTOR_LENGTH (buckets) == 0)
SCM_MISC_ERROR ("void hashtable", SCM_EOL); SCM_MISC_ERROR ("void hashtable", SCM_EOL);
scm_rec_mutex_lock (m);
k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure); k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure);
if (k >= SCM_VECTOR_LENGTH (buckets)) if (k >= SCM_VECTOR_LENGTH (buckets))
{ scm_out_of_range ("hash_fn_create_handle_x", scm_ulong2num (k));
scm_rec_mutex_unlock (m);
scm_out_of_range ("hash_fn_create_handle_x", scm_ulong2num (k));
}
it = assoc_fn (obj, SCM_VELTS (buckets)[k], closure); it = assoc_fn (obj, SCM_VELTS (buckets)[k], closure);
if (!SCM_FALSEP (it)) if (!SCM_FALSEP (it))
{ return it;
scm_rec_mutex_unlock (m);
return it;
}
else else
{ {
SCM new_bucket; SCM old_bucket = SCM_VELTS (buckets)[k];
SCM old_bucket; SCM new_bucket = scm_acons (obj, init, old_bucket);
SCM_VECTOR_SET (buckets, k, new_bucket);
if (table != buckets) if (table != buckets)
{ {
SCM_HASHTABLE_INCREMENT (table); SCM_HASHTABLE_INCREMENT (table);
@ -321,17 +311,9 @@ scm_hash_fn_create_handle_x (SCM table, SCM obj, SCM init, unsigned long (*hash_
buckets = SCM_HASHTABLE_VECTOR (table); buckets = SCM_HASHTABLE_VECTOR (table);
k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure); k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure);
if (k >= SCM_VECTOR_LENGTH (buckets)) if (k >= SCM_VECTOR_LENGTH (buckets))
{ scm_out_of_range ("hash_fn_create_handle_x", scm_ulong2num (k));
scm_rec_mutex_unlock (m);
scm_out_of_range ("hash_fn_create_handle_x",
scm_ulong2num (k));
}
} }
} }
old_bucket = SCM_VELTS (buckets)[k];
new_bucket = scm_acons (obj, init, old_bucket);
SCM_VECTOR_SET (buckets, k, new_bucket);
scm_rec_mutex_unlock (m);
return SCM_CAR (new_bucket); return SCM_CAR (new_bucket);
} }
} }
@ -373,29 +355,20 @@ scm_hash_fn_remove_x (SCM table, SCM obj, unsigned long (*hash_fn)(), SCM (*asso
{ {
unsigned long k; unsigned long k;
SCM buckets, h; SCM buckets, h;
scm_t_rec_mutex *m;
if (SCM_HASHTABLE_P (table)) if (SCM_HASHTABLE_P (table))
{ buckets = SCM_HASHTABLE_VECTOR (table);
buckets = SCM_HASHTABLE_VECTOR (table);
m = &SCM_HASHTABLE (table)->mutex;
}
else else
{ {
SCM_ASSERT (SCM_VECTORP (table), table, SCM_ARG1, "hash_fn_remove_x"); SCM_ASSERT (SCM_VECTORP (table), table, SCM_ARG1, "hash_fn_remove_x");
buckets = table; buckets = table;
m = &common_hashtable_mutex;
} }
if (SCM_VECTOR_LENGTH (table) == 0) if (SCM_VECTOR_LENGTH (table) == 0)
return SCM_EOL; return SCM_EOL;
scm_rec_mutex_lock (m);
k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure); k = hash_fn (obj, SCM_VECTOR_LENGTH (buckets), closure);
if (k >= SCM_VECTOR_LENGTH (buckets)) if (k >= SCM_VECTOR_LENGTH (buckets))
{ scm_out_of_range ("hash_fn_remove_x", scm_ulong2num (k));
scm_rec_mutex_unlock (m);
scm_out_of_range ("hash_fn_remove_x", scm_ulong2num (k));
}
h = assoc_fn (obj, SCM_VELTS (buckets)[k], closure); h = assoc_fn (obj, SCM_VELTS (buckets)[k], closure);
if (!SCM_FALSEP (h)) if (!SCM_FALSEP (h))
{ {
@ -407,7 +380,6 @@ scm_hash_fn_remove_x (SCM table, SCM obj, unsigned long (*hash_fn)(), SCM (*asso
rehash (table, hash_fn, closure); rehash (table, hash_fn, closure);
} }
} }
scm_rec_mutex_unlock (m);
return h; return h;
} }
@ -780,20 +752,12 @@ scm_internal_hash_fold (SCM (*fn) (), void *closure, SCM init, SCM table)
{ {
long i, n; long i, n;
SCM buckets, result = init; SCM buckets, result = init;
scm_t_rec_mutex *m;
if (SCM_HASHTABLE_P (table)) if (SCM_HASHTABLE_P (table))
{ buckets = SCM_HASHTABLE_VECTOR (table);
buckets = SCM_HASHTABLE_VECTOR (table);
m = &SCM_HASHTABLE (table)->mutex;
}
else else
{ buckets = table;
buckets = table;
m = &common_hashtable_mutex;
}
scm_rec_mutex_lock (m);
n = SCM_VECTOR_LENGTH (buckets); n = SCM_VECTOR_LENGTH (buckets);
for (i = 0; i < n; ++i) for (i = 0; i < n; ++i)
{ {
@ -801,22 +765,15 @@ scm_internal_hash_fold (SCM (*fn) (), void *closure, SCM init, SCM table)
while (!SCM_NULLP (ls)) while (!SCM_NULLP (ls))
{ {
if (!SCM_CONSP (ls)) if (!SCM_CONSP (ls))
{ scm_wrong_type_arg (s_scm_hash_fold, SCM_ARG3, buckets);
scm_rec_mutex_unlock (m);
scm_wrong_type_arg (s_scm_hash_fold, SCM_ARG3, buckets);
}
handle = SCM_CAR (ls); handle = SCM_CAR (ls);
if (!SCM_CONSP (handle)) if (!SCM_CONSP (handle))
{ scm_wrong_type_arg (s_scm_hash_fold, SCM_ARG3, buckets);
scm_rec_mutex_unlock (m);
scm_wrong_type_arg (s_scm_hash_fold, SCM_ARG3, buckets);
}
result = fn (closure, SCM_CAR (handle), SCM_CDR (handle), result); result = fn (closure, SCM_CAR (handle), SCM_CDR (handle), result);
ls = SCM_CDR (ls); ls = SCM_CDR (ls);
} }
} }
scm_rec_mutex_unlock (m);
return result; return result;
} }
@ -830,7 +787,6 @@ scm_init_hashtab ()
scm_set_smob_mark (scm_tc16_hashtable, scm_markcdr); scm_set_smob_mark (scm_tc16_hashtable, scm_markcdr);
scm_set_smob_print (scm_tc16_hashtable, hashtable_print); scm_set_smob_print (scm_tc16_hashtable, hashtable_print);
scm_set_smob_free (scm_tc16_hashtable, hashtable_free); scm_set_smob_free (scm_tc16_hashtable, hashtable_free);
scm_i_plugin_rec_mutex_init (&common_hashtable_mutex, &scm_i_plugin_rec_mutex);
#include "libguile/hashtab.x" #include "libguile/hashtab.x"
} }

6
libguile/weaks.c
View file

@ -183,7 +183,7 @@ SCM_DEFINE (scm_make_weak_key_hash_table, "make-weak-key-hash-table", 0, 1, 0,
#define FUNC_NAME s_scm_make_weak_key_hash_table #define FUNC_NAME s_scm_make_weak_key_hash_table
{ {
if (SCM_UNBNDP (size)) if (SCM_UNBNDP (size))
return scm_vector_to_hash_table (allocate_weak_vector (1, SCM_MAKINUM (37), return scm_vector_to_hash_table (allocate_weak_vector (1, SCM_MAKINUM (31),
SCM_EOL, FUNC_NAME)); SCM_EOL, FUNC_NAME));
else else
return allocate_weak_vector (1, size, SCM_EOL, FUNC_NAME); return allocate_weak_vector (1, size, SCM_EOL, FUNC_NAME);
@ -198,7 +198,7 @@ SCM_DEFINE (scm_make_weak_value_hash_table, "make-weak-value-hash-table", 0, 1,
#define FUNC_NAME s_scm_make_weak_value_hash_table #define FUNC_NAME s_scm_make_weak_value_hash_table
{ {
if (SCM_UNBNDP (size)) if (SCM_UNBNDP (size))
return scm_vector_to_hash_table (allocate_weak_vector (2, SCM_MAKINUM (37), return scm_vector_to_hash_table (allocate_weak_vector (2, SCM_MAKINUM (31),
SCM_EOL, FUNC_NAME)); SCM_EOL, FUNC_NAME));
else else
return allocate_weak_vector (2, size, SCM_EOL, FUNC_NAME); return allocate_weak_vector (2, size, SCM_EOL, FUNC_NAME);
@ -213,7 +213,7 @@ SCM_DEFINE (scm_make_doubly_weak_hash_table, "make-doubly-weak-hash-table", 1, 0
#define FUNC_NAME s_scm_make_doubly_weak_hash_table #define FUNC_NAME s_scm_make_doubly_weak_hash_table
{ {
if (SCM_UNBNDP (size)) if (SCM_UNBNDP (size))
return scm_vector_to_hash_table (allocate_weak_vector (3, SCM_MAKINUM (37), return scm_vector_to_hash_table (allocate_weak_vector (3, SCM_MAKINUM (31),
SCM_EOL, FUNC_NAME)); SCM_EOL, FUNC_NAME));
else else
return allocate_weak_vector (3, size, SCM_EOL, FUNC_NAME); return allocate_weak_vector (3, size, SCM_EOL, FUNC_NAME);